Skip to content

Fix loading screenshots from Debian. #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abebinder wants to merge 1 commit into from
+14 −13
Closed

Fix loading screenshots from Debian. #493

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 14 additions & 13 deletions usr/lib/linuxmint/mintinstall/imaging.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
#!/usr/bin/python3

import os
import threading
import requests
import urllib
import re
import json
import logging
from concurrent.futures import ThreadPoolExecutor

Expand Down Expand Up @@ -261,20 +260,22 @@ def _download_screenshots_thread(self):

try:
# Add additional screenshots from Debian
from bs4 import BeautifulSoup
page = BeautifulSoup(urllib.request.urlopen("https://screenshots.debian.net/package/%s" % self.pkginfo.name, timeout=5), "lxml")
images = page.findAll(href=re.compile(r"/shrine/screenshot[/\d\w]*large-[\w\d]*.png"))
for image in images:
json_url = "https://screenshots.debian.net/json/package/%s" % self.pkginfo.name
response = requests.get(json_url, timeout=5)
response.raise_for_status()
data = json.loads(response.text)

screenshots = data.get("screenshots", [])
for screenshot in screenshots:
if num_screenshots >= 4:
break

num_screenshots += 1

thumb = "https://screenshots.debian.net%s" % image['href']
local_name = os.path.join(SCREENSHOT_DIR, "%s_%s.png" % (self.pkginfo.name, num_screenshots))
self.save_to_file(thumb, None, local_name)

self.add_screenshot(self.pkginfo, local_name, num_screenshots)
screenshot_url = screenshot.get("screenshot_image_url")
if screenshot_url:
num_screenshots += 1
local_name = os.path.join(SCREENSHOT_DIR, "%s_%s.png" % (self.pkginfo.name, num_screenshots))
self.save_to_file(screenshot_url, None, local_name)
self.add_screenshot(self.pkginfo, local_name, num_screenshots)
except Exception as e:
pass

Expand Down