Fix loading screenshots from Debian.#493
Closed
abebinder wants to merge 1 commit intolinuxmint:masterfrom
Closed
Conversation
Member
|
There are very few pull requests open for this repo, but there already was one for this. |
Author
|
Sorry. Next time i'll check the open ones before making a PR. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #475
Looks like the current way of loading screenshots from screenshots.debian.net using BeautifulSoup web scraping wasn't working. I'm guessing it worked once upon a time then broke somehow when debian.net made some sort of change.
Luckily debian.net has json urls which seemed a bit better for programmatic retrieval than web scraping.
Before:
Only one screenshot
After:
Multiple screenshots