Allow x-default hreflang also if multiple alternate links are available#163
Open
markusreis wants to merge 2 commits intolloc:masterfrom
Open
Allow x-default hreflang also if multiple alternate links are available#163markusreis wants to merge 2 commits intolloc:masterfrom
markusreis wants to merge 2 commits intolloc:masterfrom
Conversation
…eflang node if more than one alternate links exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Dennis,
another filter request:
In your output code, the x-default only gets printed if there is only one alternate-link available. However, when for example offering two options
alternate="de_DE"andalternate="en_US"you still might want to offer anx-defaultfor all users from other countries. With this change you can then simply set the following to append the x-default link to the output for the desired default blog:Will also solve this guys problem https://wordpress.org/support/topic/x-default-hreflang/ ;)
Cheers!