Made TZ pattern more inclusive to all timezone patterns of the world#235
Made TZ pattern more inclusive to all timezone patterns of the world#235robin13 wants to merge 1 commit intologstash-plugins:mainfrom
Conversation
|
#230 ?? and include the regex I built with the suggest MIL pattern instead of the |
|
Regarding #230: I've not seen lowercase timezone in the wild and am doubtful if that is really a pattern which should be matched as standard. |
|
This is looking legit, I am scraping through PRs and see TZ is still an issue: I do like what Guy suggested at #172 which this issue is aiming to fix: which is a bit of a regexp but still won't much 'arbitrary' text .. regarding MIL zones I am actually not sure (would leave those out of the discussion). @robin13 are you still interested in this (it's fine to not be in which case we should discuss whether it's worth keeping this one open) ? |
|
@kares I also like the suggestion made by Guy. |
|
Coming to get some news about this PR since TZ is still an issue around here (Europe). We recently had a nice outage cause CET and CEST are not matched by the old pattern.
Would you like us to modify your PR with Guy's suggestion? Or can this PR be merged in this state ? Thanks in advance! |
fixes #172