feat: add onPress and onLongPress events to MapView#35
Merged
Conversation
Rename native press events so polygon onPress doesn't bubble to MapView: - MapView: onMapPress, onMapLongPress (DirectEventHandler) - Polygon: onPolygonPress (DirectEventHandler) Public JS API (onPress/onLongPress) unchanged — mapping in component layer.
Polygons are always clickable to intercept taps. If not tappable, forward to onMapClick with actual tap coordinate captured via dispatchTouchEvent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onPressandonLongPressevents toMapViewreturning coordinate and screen pointonMapPress,onMapLongPress,onPolygonPress) to prevent event bubbling between componentsType of Change
Test Plan
onPressfires with correct coordinate and screen pointonLongPressfires with correct coordinate and screen pointonPresshandler → polygon press fires, map press does notonPresshandler → map press fires with correct coordinateonLongPressfires, notonPress(Apple Maps)Checklist