Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the sample app's usability for testing custom layouts by adding a text input field for custom placement identifiers and improving the UI/UX with better keyboard handling and visual design updates. The changes also include dependency updates via yarn.lock and streamlined installation instructions.
Changes:
- Added custom layout identifier text input with improved UI styling
- Implemented keyboard-aware scrolling with SafeAreaView and KeyboardAvoidingView
- Updated iOS configuration and simplified onboarding documentation
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sample/yarn.lock | Updated JavaScript dependencies to latest versions |
| sample/package.json | Added postinstall script to automatically install iOS pods |
| sample/index.js | Added custom identifier input, improved UI with better styling and keyboard handling |
| sample/ios/MParticleSample/AppDelegate.mm | Updated mParticle initialization with debug logging and production environment |
| sample/ios/MParticleSample.xcodeproj/project.pbxproj | Added development team ID and updated Xcode build configuration |
| ONBOARDING.md | Simplified setup instructions by removing manual pod install step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Tested locally and verified with live stream
Master Issue
Closes N/A