Skip to content

simple fix for invalid sql #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthew-marston wants to merge 1 commit into
base: master
Choose a base branch
from
Open

simple fix for invalid sql #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/DistributedLock.Oracle/OracleDatabaseConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,15 @@ private OracleDatabaseConnection(IDbConnection connection, bool isExternallyOwne
// from https://docs.oracle.com/html/E10927_01/OracleCommandClass.htm "this method is a no-op" wrt "Prepare()"
public override bool ShouldPrepareCommands => false;

public override bool IsCommandCancellationException(Exception exception) =>
public override bool IsCommandCancellationException(Exception exception) =>
exception is OracleException oracleException
// based on https://docs.oracle.com/cd/E85694_01/ODPNT/CommandCancel.htm
&& (oracleException.Number == 01013 || oracleException.Number == 00936 || oracleException.Number == 00604);

public override async Task SleepAsync(TimeSpan sleepTime, CancellationToken cancellationToken, Func<DatabaseCommand, CancellationToken, ValueTask<int>> executor)
{
using var sleepCommand = this.CreateCommand();
sleepCommand.SetCommandText("BEGIN sys.DBMS_SESSION.SLEEP(:seconds) END;");
sleepCommand.SetCommandText("BEGIN sys.DBMS_SESSION.SLEEP(:seconds); END;");
sleepCommand.AddParameter("seconds", sleepTime.TotalSeconds);

try
Expand Down