You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@alancnet sorry for taking so long on this but few of the tasks for 0.2.x release took a lot longer than I expected. I finally had sometime to play with your code and it is quite nice the way you implemented it.
However, as it currently stand, I and not sure how it will fit with angularAMD in general due to angularAMD's tight coupling with RequireJS. More specifically, angularAMD's main objective is allow for r.js optimisation. To do that, all module need to be defined using RequireJS' define syntax. There is also no interaction between amd-require with angularAMD itself so your directive could very well be an independent component.
The trick here is to figure out how to expose amd-require dependencies for r.js. I did an initial research and the only thing that came up is to generate a build.js file by parsing Javascript, and in this case, HTML. There gotta be a better way...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.