Skip to content

Phonon focusing fix#2343

Open
Lomholy wants to merge 8 commits intomainfrom
phonon_focusing_fix
Open

Phonon focusing fix#2343
Lomholy wants to merge 8 commits intomainfrom
phonon_focusing_fix

Conversation

@Lomholy
Copy link
Collaborator

@Lomholy Lomholy commented Feb 24, 2026

Free-form text area

Please describe what your PR is adding in terms of features or bugfixes:
Added in a conversion from Degrees to radians inside the initialize of Phonon_simple, such that it is consistent with its header.


Development OS / boundary conditions

Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
MacOS Tahoe 26.3


PR Checklist for contributing to McStas/McXtrace

For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:

  • My contribution includes patches to an existing component file

    • I have used the mcdoc utility and rendered a reasonable documentation page for the component (please attach as screenshot in comments!)
    • I have ensured that basic use of the component is OK (e.g. an instrument using it compiles?)
    • I have used the mctest utility to test one or more instruments making use of the component (please attach mcviewtest report as screenshot in comments)
    • I have used the mccode-clangformat tool to apply the standard McCode component indentation scheme
    • I have used the mcrun --c-lint "linter" and followed advice to remove most / all warnings that are raised

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant