Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Pull request overview
Adds a new STACKIT “SKE Starterkit” module intended to register a meshStack building block that provisions dev/prod projects and SKE tenants.
Changes:
- Introduces
meshstack_integration.tfto register the SKE Starterkit building block in meshStack. - Adds the building block Terraform code to create dev/prod projects, creator admin bindings, and dev/prod tenants.
- Adds input variable definitions (including YAML-based project tagging with validation).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| modules/stackit/ske-starterkit/meshstack_integration.tf | Defines the building block definition and its inputs/permissions for registration in meshStack. |
| modules/stackit/ske-starterkit/buildingblock/main.tf | Provisions dev/prod meshStack projects, assigns creator admin role, and creates dev/prod tenants. |
| modules/stackit/ske-starterkit/buildingblock/variables.tf | Declares required building block inputs including YAML tag configuration and validations. |
| variable "workspace_identifier" { | ||
| type = string | ||
| } | ||
|
|
||
| variable "name" { |
There was a problem hiding this comment.
Compared to other modules under modules/*/*/buildingblock/, this new building block directory is missing the standard companion files (e.g., README.md with YAML front-matter, APP_TEAM_README.md, logo.png, outputs.tf, provider.tf, versions.tf). Please add these to match the repo’s module structure and ensure the Hub UI/CI tooling can render and validate the module properly.
| } | ||
| } | ||
|
|
||
| variable "owned_by_workspace" { |
There was a problem hiding this comment.
Inconsistent input naming vs other STACKIT meshstack_integration examples: this file uses owned_by_workspace, but modules/stackit/git-repository/meshstack_integration.tf uses owning_workspace_identifier. Consider renaming the variable to owning_workspace_identifier (and updating references) to avoid confusion and keep module registrations consistent.
| variable "owned_by_workspace" { | |
| variable "owning_workspace_identifier" { |
🎨 Missing Building Block IconsFound 1 building block(s) without Copy the AI Prompts below and use them with your favorite AI image generator (Gemini, DALL-E, Midjourney, Stable Diffusion, etc.). Then follow the Post-Processing Steps to prepare the icons for upload. Azure Virtual Machine StarterkitPlatform: Path: AI Prompt (copy this to image generator)Post-Processing InstructionsStep 1: Remove white background with GIMP (free) a) Open image in GIMP Step 2: Resize to 800x800 pixels if needed
Step 3: Compress with pngquant (free command line tool)
Target specs: 800x800px PNG with transparent background, under 100KB |
No description provided.