Conversation
Honigeintopf
changed the title
Gerrit91
changed the title
Gerrit91
left a comment
Gerrit91
left a comment
There was a problem hiding this comment.
Thanks for coming up with a PR for this.
controllers/set/status.go
Outdated
| if fw.Status.Phase == v2.FirewallPhaseCreating && timeSinceReconcile > allocationTimeout { | ||
| c.log.Info("create timeout reached") | ||
| return firewallConditionStatus{CreateTimeout: true} | ||
| } | ||
|
|
||
| if seedConnected && unhealthyTimeout != 0 && created && timeSinceReconcile > unhealthyTimeout { |
There was a problem hiding this comment.
Check if allocationTimeout is set to be able to disable this check
Co-authored-by: Gerrit <Gerrit91@users.noreply.github.com>
Co-authored-by: Gerrit <Gerrit91@users.noreply.github.com>
Co-authored-by: Gerrit <Gerrit91@users.noreply.github.com>
Co-authored-by: Gerrit <Gerrit91@users.noreply.github.com>
|
Test needs adaption (fake one of the unhealthy conditions). |
|
I changed a line in the code to only apply health timeout once we have a non-zero seed reconcile timestamp and made possible to specify 0s as timeout which translates to disabling the deletion. |
|
Okay the issue with using FirewallPhaseRunning:
So either we go ahead and fix when a fw is running( I wouldn't do that) or we say hey there is a new fw condition when the fw was ready once i.e. it finished progressing |
|
Is it an issue if the firewall is phoned home and entered the running phase and the firewall is unhealthy until the firewall controller connects? It should not take longer than a minute anyway? |
|
No, it's not an issue. During the window between phoned-home and firewall-controller-connecting, the FirewallHealthy condition(It's a new one) hasn't been set yet (it's only set once ALL conditions are met for the first time) |
|
Okay, I see now where you want to go, I will comment in the code. |
Co-authored-by: Gerrit <Gerrit91@users.noreply.github.com>
3 participants
Description
Closes #62.
This pr introduces the functionality for deleting firewalls if they exceed the firewallHealthTimeout which for now is set to 20 minutes.
Integration tests where added to make sure everything works as intended.
CA were updated, otherwise it is not possible to deploy to mini-lab.