Fix resource leaks in DirectLineStreaming after end() is called#452
Open
orgads wants to merge 1 commit intomicrosoft:masterfrom
Open
Fix resource leaks in DirectLineStreaming after end() is called#452orgads wants to merge 1 commit intomicrosoft:masterfrom
orgads wants to merge 1 commit intomicrosoft:masterfrom
Conversation
orgads
force-pushed
the
dl-streaming-leaks
branch
from
28137d4 to
61c087b
Compare
- Cancel pending timers on end() via AbortController-aware sleep() - Stop refreshToken() loop early on abort and after fatal 403 - Unsubscribe from connectionStatus$ in waitUntilOnline() on resolve/reject - Use cancellable sleep() for retry delays in connectWithRetryAsync() - Add unit tests covering all leak fixes (sync and async paths) Fixes microsoft#433
orgads
force-pushed
the
dl-streaming-leaks
branch
from
61c087b to
9f85399
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #433