Refactor Keithley 2600 driver to use ParameterWithSetpoints for fast sweep#7851
Draft
trlemon wants to merge 31 commits intomicrosoft:mainfrom
Draft
Refactor Keithley 2600 driver to use ParameterWithSetpoints for fast sweep#7851trlemon wants to merge 31 commits intomicrosoft:mainfrom
ParameterWithSetpoints for fast sweep#7851trlemon wants to merge 31 commits intomicrosoft:mainfrom
Conversation
…s://github.com/trlemon/Qcodes into trlemon/refactor-keithley2600-driver-fastsweep
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7851 +/- ##
==========================================
+ Coverage 59.94% 60.20% +0.26%
==========================================
Files 352 352
Lines 31933 32075 +142
==========================================
+ Hits 19143 19312 +169
+ Misses 12790 12763 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jenshnielsen
reviewed
Feb 9, 2026
jenshnielsen
reviewed
Feb 9, 2026
jenshnielsen
reviewed
Feb 9, 2026
…s://github.com/trlemon/Qcodes into trlemon/refactor-keithley2600-driver-fastsweep
…s://github.com/trlemon/Qcodes into trlemon/refactor-keithley2600-driver-fastsweep
astafan8
reviewed
Feb 20, 2026
astafan8
reviewed
Mar 2, 2026
astafan8
approved these changes
Mar 4, 2026
Contributor
astafan8
left a comment
There was a problem hiding this comment.
is it ready for the final review, can it exit the draft mode? :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The
doFastSweepmethod relies on "old" technology fromqcodes_loop, and it also returns a Qcodes dataset which may not be desirable for all applications. Instead, it would be better to useParameterWithSetpointsand return a numpy array.Summary of Changes
qcodes_loop