Improvement: added shapes to DatasetDefinition#7891
Improvement: added shapes to DatasetDefinition#7891esbenh4 wants to merge 4 commits intomicrosoft:mainfrom
Conversation
…ent. extended tests to cover new uses.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7891 +/- ##
==========================================
- Coverage 59.94% 59.94% -0.01%
==========================================
Files 352 352
Lines 31933 31937 +4
==========================================
+ Hits 19143 19145 +2
- Misses 12790 12792 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@microsoft-github-policy-service agree company="Microsoft" |
Co-authored-by: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
Co-authored-by: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
|
This implementation looks sound to me, but I do have a question: What happens if the shape specified here does not match what ends up being actually recorded? e.g. if I specify a DataSetDefinition that includes 11 B-Field points, but I actually take 13, when does the error occur? |
At the moment, nothing. THis is also true for the set_shape method on the Measurement context manager itself. It is up to the users to not "lie" when they set the shape and do the measurement. It is a very good question to raise, however adressing it is an endevour of its own, so let's skip it for this PR. |
Enabled use of shape in DatasetDefinition to set shape of measurement when using datasaver_builder to create measurements.