Remove the specialcase intended for `strictNullChecks: false` in `Awaited` by Andarist · Pull Request #52949 · microsoft/TypeScript

Andarist · 2023-02-24T10:02:56Z

A colleague of mine asked me why this branch is needed here. I couldn't figure it out so I decided to run the TS test suite without this to learn more about it... but the whole thing just passed.

There are two possible situations here:

this is redundant
the test suite lacks the appropriate test case

If it's the second situation - then I would appreciate if somebody could provide that test case so I could add it, cause I don't know what that would look like.

This type was added here with this special branch there, right from the start. cc @rbuckton

…ited`

typescript-bot · 2023-02-24T10:03:10Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

RyanCavanaugh · 2023-02-24T16:23:51Z

Maybe this will help, not sure:

@typescript-bot test this
@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt

typescript-bot · 2023-02-24T16:23:54Z

Heya @RyanCavanaugh, I've started to run the extended test suite on this PR at 7e8f046. You can monitor the build here.

typescript-bot · 2023-02-24T16:23:54Z

Heya @RyanCavanaugh, I've started to run the parallelized Definitely Typed test suite on this PR at 7e8f046. You can monitor the build here.

typescript-bot · 2023-02-24T16:23:54Z

Heya @RyanCavanaugh, I've started to run the diff-based top-repos suite on this PR at 7e8f046. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-24T16:23:54Z

Heya @RyanCavanaugh, I've started to run the diff-based user code test suite on this PR at 7e8f046. You can monitor the build here.

Update: The results are in!

jakebailey · 2023-02-24T16:25:43Z

Not sure if our benchmarks use it but it's less work to do while checking so maybe...

@typescript-bot perf test this

typescript-bot · 2023-02-24T16:25:45Z

Heya @jakebailey, I've started to run the perf test suite on this PR at 7e8f046. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-02-24T16:37:16Z

@RyanCavanaugh Here are the results of running the user test suite comparing main and refs/pull/52949/merge:

Everything looks good!

typescript-bot · 2023-02-24T17:20:02Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..52949

_Metric	_main	₅₂₉₄₉	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{359,718k (± 0.02%)}	_{359,740k (± 0.01%)}	_~	_359,661k	_359,785k	_{p=0.689 n=6}
_{Parse Time}	_{3.49s (± 0.66%)}	_{3.48s (± 1.05%)}	_~	_3.44s	_3.54s	_{p=0.872 n=6}
_{Bind Time}	_{1.13s (± 0.67%)}	_{1.13s (± 0.72%)}	_~	_1.12s	_1.14s	_{p=0.729 n=6}
_{Check Time}	_{8.67s (± 0.69%)}	_{8.67s (± 0.49%)}	_~	_8.60s	_8.72s	_{p=1.000 n=6}
_{Emit Time}	_{7.46s (± 0.81%)}	_{7.47s (± 0.81%)}	_~	_7.40s	_7.56s	_{p=1.000 n=6}
_{Total Time}	_{20.75s (± 0.51%)}	_{20.75s (± 0.27%)}	_~	_20.65s	_20.80s	_{p=0.335 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{190,717k (± 1.24%)}	_{192,986k (± 1.46%)}	_~	_189,635k	_195,568k	_{p=0.378 n=6}
_{Parse Time}	_{1.49s (± 1.39%)}	_{1.49s (± 1.17%)}	_~	_1.47s	_1.52s	_{p=0.565 n=6}
_{Bind Time}	_{0.78s (± 1.05%)}	_{0.77s (± 1.06%)}	_~	_0.76s	_0.78s	_{p=0.077 n=6}
_{Check Time}	_{9.42s (± 0.52%)}	_{9.37s (± 0.42%)}	_~	_9.32s	_9.42s	_{p=0.078 n=6}
_{Emit Time}	_{2.77s (± 0.68%)}	_{2.74s (± 0.58%)}	_~	_2.72s	_2.76s	_{p=0.051 n=6}
_{Total Time}	_{14.45s (± 0.36%)}	_{14.37s (± 0.26%)}	_{-0.08s (- 0.54%)}	_14.34s	_14.44s	_{p=0.015 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{343,839k (± 0.01%)}	_{343,827k (± 0.01%)}	_~	_343,793k	_343,884k	_{p=0.422 n=6}
_{Parse Time}	_{2.64s (± 1.06%)}	_{2.61s (± 1.02%)}	_~	_2.58s	_2.64s	_{p=0.226 n=6}
_{Bind Time}	_{1.01s (± 0.51%)}	_{1.01s (± 0.40%)}	_~	_1.00s	_1.01s	_{p=0.114 n=6}
_{Check Time}	_{7.05s (± 0.23%)}	_{7.00s (± 0.33%)}	_{-0.05s (- 0.64%)}	_6.98s	_7.04s	_{p=0.012 n=6}
_{Emit Time}	_{4.21s (± 0.59%)}	_{4.22s (± 0.76%)}	_~	_4.17s	_4.25s	_{p=0.466 n=6}
_{Total Time}	_{14.91s (± 0.37%)}	_{14.85s (± 0.26%)}	_~	_14.79s	_14.90s	_{p=0.077 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{299,858k (± 0.01%)}	_{299,864k (± 0.01%)}	_~	_299,844k	_299,888k	_{p=0.936 n=6}
_{Parse Time}	_{2.07s (± 1.13%)}	_{2.06s (± 1.25%)}	_~	_2.02s	_2.10s	_{p=0.222 n=6}
_{Bind Time}	_{1.14s (± 0.73%)}	_{1.13s (± 0.48%)}	_{-0.01s (- 0.87%)}	_1.13s	_1.14s	_{p=0.038 n=6}
_{Check Time}	_{6.53s (± 0.35%)}	_{6.49s (± 0.28%)}	_{-0.04s (- 0.59%)}	_6.47s	_6.51s	_{p=0.024 n=6}
_{Emit Time}	_{3.87s (± 1.02%)}	_{3.85s (± 0.67%)}	_~	_3.81s	_3.89s	_{p=0.747 n=6}
_{Total Time}	_{13.61s (± 0.42%)}	_{13.54s (± 0.26%)}	_{-0.07s (- 0.55%)}	_13.50s	_13.59s	_{p=0.024 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{476,424k (± 0.00%)}	_{476,386k (± 0.00%)}	_{-38k (- 0.01%)}	_476,356k	_476,407k	_{p=0.024 n=6}
_{Parse Time}	_{3.17s (± 0.61%)}	_{3.15s (± 0.74%)}	_~	_3.12s	_3.18s	_{p=0.124 n=6}
_{Bind Time}	_{0.91s (± 0.45%)}	_{0.91s (± 0.57%)}	_~	_0.90s	_0.91s	_{p=0.114 n=6}
_{Check Time}	_{17.17s (± 0.87%)}	_{17.06s (± 0.54%)}	_~	_16.97s	_17.17s	_{p=0.173 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.25s (± 0.66%)}	_{21.11s (± 0.40%)}	_~	_21.02s	_21.21s	_{p=0.173 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{548,237k (± 0.04%)}	_{548,138k (± 0.03%)}	_~	_547,948k	_548,374k	_{p=0.471 n=6}
_{Parse Time}	_{4.08s (± 0.69%)}	_{4.08s (± 0.61%)}	_~	_4.05s	_4.11s	_{p=1.000 n=6}
_{Bind Time}	_{1.67s (± 0.99%)}	_{1.66s (± 0.49%)}	_~	_1.65s	_1.67s	_{p=1.000 n=6}
_{Check Time}	_{2.79s (± 0.70%)}	_{2.77s (± 0.27%)}	_~	_2.76s	_2.78s	_{p=0.164 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.62s (± 0.54%)}	_{8.59s (± 0.24%)}	_~	_8.57s	_8.62s	_{p=0.366 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{359,035k (± 0.01%)}	_{359,044k (± 0.01%)}	_~	_359,022k	_359,079k	_{p=0.575 n=6}
_{Parse Time}	_{3.73s (± 0.80%)}	_{3.72s (± 0.40%)}	_~	_3.69s	_3.73s	_{p=0.513 n=6}
_{Bind Time}	_{1.19s (± 0.63%)}	_{1.19s (± 0.34%)}	_~	_1.18s	_1.19s	_{p=0.389 n=6}
_{Check Time}	_{9.45s (± 0.64%)}	_{9.42s (± 0.40%)}	_~	_9.40s	_9.50s	_{p=0.220 n=6}
_{Emit Time}	_{7.93s (± 0.62%)}	_{7.91s (± 0.63%)}	_~	_7.83s	_7.98s	_{p=0.625 n=6}
_{Total Time}	_{22.31s (± 0.52%)}	_{22.24s (± 0.31%)}	_~	_22.15s	_22.36s	_{p=0.225 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{191,374k (± 0.04%)}	_{191,409k (± 0.03%)}	_~	_191,352k	_191,487k	_{p=0.471 n=6}
_{Parse Time}	_{1.59s (± 1.31%)}	_{1.55s (± 1.35%)}	_{-0.04s (- 2.21%)}	_1.52s	_1.57s	_{p=0.023 n=6}
_{Bind Time}	_{0.83s (± 0.49%)}	_{0.82s (± 0.63%)}	_{-0.01s (- 1.41%)}	_0.81s	_0.82s	_{p=0.007 n=6}
_{Check Time}	_{10.09s (± 0.27%)}	_{10.03s (± 0.74%)}	_~	_9.91s	_10.12s	_{p=0.197 n=6}
_{Emit Time}	_{3.04s (± 0.77%)}	_{3.01s (± 0.44%)}	_{-0.03s (- 0.93%)}	_2.99s	_3.03s	_{p=0.033 n=6}
_{Total Time}	_{15.54s (± 0.24%)}	_{15.41s (± 0.57%)}	_{-0.12s (- 0.79%)}	_15.27s	_15.51s	_{p=0.013 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{343,078k (± 0.00%)}	_{343,091k (± 0.01%)}	_~	_343,064k	_343,121k	_{p=0.378 n=6}
_{Parse Time}	_{2.81s (± 0.52%)}	_{2.80s (± 0.69%)}	_~	_2.78s	_2.83s	_{p=0.370 n=6}
_{Bind Time}	_{1.09s (± 0.58%)}	_{1.09s (± 1.07%)}	_~	_1.08s	_1.11s	_{p=0.485 n=6}
_{Check Time}	_{7.69s (± 0.67%)}	_{7.67s (± 0.54%)}	_~	_7.62s	_7.74s	_{p=0.630 n=6}
_{Emit Time}	_{4.45s (± 1.41%)}	_{4.42s (± 0.77%)}	_~	_4.38s	_4.47s	_{p=0.573 n=6}
_{Total Time}	_{16.04s (± 0.63%)}	_{15.98s (± 0.36%)}	_~	_15.93s	_16.09s	_{p=0.468 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{299,217k (± 0.01%)}	_{299,236k (± 0.01%)}	_~	_299,221k	_299,260k	_{p=0.128 n=6}
_{Parse Time}	_{2.20s (± 0.85%)}	_{2.19s (± 0.61%)}	_~	_2.17s	_2.20s	_{p=0.554 n=6}
_{Bind Time}	_{1.24s (± 1.10%)}	_{1.25s (± 1.63%)}	_~	_1.21s	_1.27s	_{p=0.157 n=6}
_{Check Time}	_{7.17s (± 0.58%)}	_{7.17s (± 0.52%)}	_~	_7.10s	_7.21s	_{p=0.809 n=6}
_{Emit Time}	_{4.34s (± 0.70%)}	_{4.33s (± 0.69%)}	_~	_4.28s	_4.36s	_{p=0.687 n=6}
_{Total Time}	_{14.94s (± 0.52%)}	_{14.93s (± 0.51%)}	_~	_14.78s	_14.98s	_{p=1.000 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{475,712k (± 0.01%)}	_{475,728k (± 0.01%)}	_~	_475,683k	_475,801k	_{p=0.378 n=6}
_{Parse Time}	_{3.33s (± 0.41%)}	_{3.33s (± 0.16%)}	_~	_3.32s	_3.33s	_{p=0.341 n=6}
_{Bind Time}	_{0.96s (± 0.54%)}	_{0.96s (± 0.00%)}	_~	_0.96s	_0.96s	_{p=0.174 n=6}
_{Check Time}	_{18.11s (± 0.47%)}	_{18.04s (± 0.25%)}	_~	_17.97s	_18.11s	_{p=0.148 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.41s (± 0.37%)}	_{22.33s (± 0.23%)}	_~	_22.24s	_22.40s	_{p=0.077 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{545,722k (± 0.01%)}	_{545,744k (± 0.02%)}	_~	_545,642k	_545,893k	_{p=0.936 n=6}
_{Parse Time}	_{4.27s (± 0.21%)}	_{4.25s (± 0.23%)}	_{-0.02s (- 0.51%)}	_4.24s	_4.26s	_{p=0.011 n=6}
_{Bind Time}	_{1.75s (± 0.72%)}	_{1.74s (± 0.60%)}	_~	_1.72s	_1.75s	_{p=0.067 n=6}
_{Check Time}	_{2.99s (± 0.51%)}	_{2.99s (± 0.25%)}	_~	_2.98s	_3.00s	_{p=0.363 n=6}
_{Emit Time}	_{0.09s (± 5.53%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=0.174 n=6}
_{Total Time}	_{9.11s (± 0.28%)}	_{9.07s (± 0.24%)}	_{-0.04s (- 0.49%)}	_9.04s	_9.10s	_{p=0.019 n=6}
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{352,779k (± 0.00%)}	_{352,780k (± 0.00%)}	_~	_352,767k	_352,807k	_{p=0.936 n=6}
_{Parse Time}	_{3.76s (± 0.50%)}	_{3.71s (± 0.37%)}	_{-0.05s (- 1.24%)}	_3.70s	_3.73s	_{p=0.007 n=6}
_{Bind Time}	_{1.26s (± 0.67%)}	_{1.25s (± 0.44%)}	_{-0.01s (- 0.80%)}	_1.24s	_1.25s	_{p=0.038 n=6}
_{Check Time}	_{9.74s (± 0.62%)}	_{9.72s (± 0.68%)}	_~	_9.65s	_9.84s	_{p=0.520 n=6}
_{Emit Time}	_{8.39s (± 0.56%)}	_{8.34s (± 0.87%)}	_~	_8.26s	_8.45s	_{p=0.196 n=6}
_{Total Time}	_{23.16s (± 0.28%)}	_{23.02s (± 0.56%)}	_{-0.14s (- 0.59%)}	_22.88s	_23.24s	_{p=0.045 n=6}
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{186,599k (± 0.01%)}	_{186,614k (± 0.02%)}	_~	_186,563k	_186,645k	_{p=0.336 n=6}
_{Parse Time}	_{1.59s (± 0.65%)}	_{1.59s (± 0.86%)}	_~	_1.57s	_1.61s	_{p=0.315 n=6}
_{Bind Time}	_{0.85s (± 0.61%)}	_{0.84s (± 0.49%)}	_{-0.01s (- 0.98%)}	_0.83s	_0.84s	_{p=0.022 n=6}
_{Check Time}	_{10.21s (± 0.15%)}	_{10.19s (± 0.67%)}	_~	_10.11s	_10.28s	_{p=0.806 n=6}
_{Emit Time}	_{3.13s (± 0.96%)}	_{3.12s (± 0.99%)}	_~	_3.08s	_3.17s	_{p=0.624 n=6}
_{Total Time}	_{15.78s (± 0.20%)}	_{15.73s (± 0.44%)}	_~	_15.63s	_15.79s	_{p=0.258 n=6}
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{338,068k (± 0.01%)}	_{338,056k (± 0.01%)}	_~	_338,026k	_338,083k	_{p=1.000 n=6}
_{Parse Time}	_{2.91s (± 0.40%)}	_{2.89s (± 0.28%)}	_{-0.02s (- 0.52%)}	_2.88s	_2.90s	_{p=0.048 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.09s (± 0.69%)}	_~	_1.08s	_1.10s	_{p=0.784 n=6}
_{Check Time}	_{8.10s (± 0.19%)}	_{8.08s (± 0.35%)}	_~	_8.05s	_8.12s	_{p=0.357 n=6}
_{Emit Time}	_{4.69s (± 1.27%)}	_{4.68s (± 1.06%)}	_~	_4.63s	_4.76s	_{p=0.810 n=6}
_{Total Time}	_{16.79s (± 0.44%)}	_{16.75s (± 0.35%)}	_~	_16.70s	_16.86s	_{p=0.296 n=6}
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{294,260k (± 0.00%)}	_{294,257k (± 0.00%)}	_~	_294,237k	_294,269k	_{p=0.810 n=6}
_{Parse Time}	_{2.40s (± 0.63%)}	_{2.39s (± 0.89%)}	_~	_2.37s	_2.43s	_{p=0.139 n=6}
_{Bind Time}	_{1.08s (± 0.91%)}	_{1.07s (± 1.45%)}	_~	_1.06s	_1.09s	_{p=0.149 n=6}
_{Check Time}	_{7.45s (± 0.38%)}	_{7.49s (± 0.40%)}	_{+0.04s (+ 0.49%)}	_7.43s	_7.52s	_{p=0.029 n=6}
_{Emit Time}	_{4.30s (± 1.34%)}	_{4.30s (± 0.69%)}	_~	_4.27s	_4.34s	_{p=0.809 n=6}
_{Total Time}	_{15.24s (± 0.37%)}	_{15.24s (± 0.45%)}	_~	_15.13s	_15.31s	_{p=0.810 n=6}
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{471,351k (± 0.00%)}	_{471,378k (± 0.00%)}	_~	_471,369k	_471,388k	_{p=0.066 n=6}
_{Parse Time}	_{3.51s (± 0.38%)}	_{3.51s (± 0.36%)}	_~	_3.49s	_3.52s	_{p=0.788 n=6}
_{Bind Time}	_{1.00s (± 0.81%)}	_{1.00s (± 0.52%)}	_~	_0.99s	_1.00s	_{p=0.140 n=6}
_{Check Time}	_{18.95s (± 0.55%)}	_{19.00s (± 0.43%)}	_~	_18.94s	_19.14s	_{p=0.809 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.46s (± 0.46%)}	_{23.50s (± 0.38%)}	_~	_23.44s	_23.66s	_{p=0.936 n=6}
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{534,456k (± 0.01%)}	_{534,448k (± 0.00%)}	_~	_534,420k	_534,480k	_{p=1.000 n=6}
_{Parse Time}	_{4.61s (± 0.59%)}	_{4.57s (± 0.33%)}	_{-0.04s (- 0.76%)}	_4.56s	_4.60s	_{p=0.024 n=6}
_{Bind Time}	_{1.67s (± 0.73%)}	_{1.66s (± 0.62%)}	_~	_1.64s	_1.67s	_{p=0.210 n=6}
_{Check Time}	_{3.15s (± 0.84%)}	_{3.14s (± 0.47%)}	_~	_3.12s	_3.16s	_{p=0.419 n=6}
_{Emit Time}	_{0.10s (± 4.15%)}	_{0.10s (± 0.00%)}	_~	_0.10s	_0.10s	_{p=0.405 n=6}
_{Total Time}	_{9.54s (± 0.41%)}	_{9.48s (± 0.34%)}	_{-0.06s (- 0.58%)}	_9.44s	_9.52s	_{p=0.020 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₉₄₉	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..52949

_Metric	_main	₅₂₉₄₉	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,362ms (± 0.75%)}	_{2,375ms (± 0.62%)}	_~	_2,351ms	_2,391ms	_{p=0.261 n=6}
_{Req 2 - geterr}	_{5,313ms (± 0.85%)}	_{5,285ms (± 0.41%)}	_~	_5,255ms	_5,315ms	_{p=0.378 n=6}
_{Req 3 - references}	_{338ms (± 0.73%)}	_{338ms (± 0.60%)}	_~	_336ms	_342ms	_{p=0.806 n=6}
_{Req 4 - navto}	_{286ms (± 0.79%)}	_{284ms (± 1.25%)}	_~	_280ms	_289ms	_{p=0.291 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{72ms (± 1.14%)}	_{72ms (± 4.21%)}	_~	_70ms	_78ms	_{p=0.451 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,482ms (± 0.99%)}	_{2,465ms (± 0.64%)}	_~	_2,450ms	_2,483ms	_{p=0.148 n=6}
_{Req 2 - geterr}	_{3,988ms (± 0.56%)}	_{3,975ms (± 0.63%)}	_~	_3,933ms	_4,011ms	_{p=0.298 n=6}
_{Req 3 - references}	_{351ms (± 0.58%)}	_{354ms (± 1.18%)}	_~	_351ms	_362ms	_{p=0.285 n=6}
_{Req 4 - navto}	_{293ms (± 0.35%)}	_{292ms (± 0.60%)}	_~	_290ms	_295ms	_{p=0.162 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{68ms (± 1.79%)}	_{68ms (± 1.24%)}	_~	_67ms	_69ms	_{p=1.000 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,170ms (± 0.73%)}	_{3,153ms (± 0.59%)}	_~	_3,139ms	_3,182ms	_{p=0.128 n=6}
_{Req 2 - geterr}	_{1,608ms (± 0.87%)}	_{1,611ms (± 0.86%)}	_~	_1,588ms	_1,627ms	_{p=0.810 n=6}
_{Req 3 - references}	_{102ms (± 1.18%)}	_{103ms (± 2.74%)}	_~	_100ms	_108ms	_{p=0.935 n=6}
_{Req 4 - navto}	_{359ms (± 0.69%)}	_{359ms (± 1.16%)}	_~	_355ms	_366ms	_{p=0.872 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,136 (± 0.00%)}	_~	_3,136	_3,136	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{431ms (± 0.72%)}	_{429ms (± 1.47%)}	_~	_418ms	_436ms	_{p=0.627 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,536ms (± 1.00%)}	_{2,523ms (± 0.43%)}	_~	_2,515ms	_2,543ms	_{p=0.199 n=6}
_{Req 2 - geterr}	_{5,714ms (± 0.38%)}	_{5,691ms (± 0.73%)}	_~	_5,651ms	_5,766ms	_{p=0.173 n=6}
_{Req 3 - references}	_{353ms (± 1.44%)}	_{354ms (± 1.14%)}	_~	_348ms	_360ms	_{p=0.872 n=6}
_{Req 4 - navto}	_{279ms (± 0.64%)}	_{280ms (± 0.29%)}	_~	_279ms	_281ms	_{p=0.677 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (± 4.40%)}	_{83ms (± 4.63%)}	_~	_76ms	_87ms	_{p=0.627 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,665ms (± 0.43%)}	_{2,653ms (± 0.36%)}	_~	_2,641ms	_2,668ms	_{p=0.078 n=6}
_{Req 2 - geterr}	_{4,363ms (± 0.59%)}	_{4,352ms (± 0.31%)}	_~	_4,339ms	_4,377ms	_{p=0.261 n=6}
_{Req 3 - references}	_{363ms (± 1.25%)}	_{365ms (± 1.27%)}	_~	_358ms	_370ms	_{p=0.466 n=6}
_{Req 4 - navto}	_{292ms (± 1.38%)}	_{286ms (± 1.08%)}	_{-6ms (- 1.89%)}	_283ms	_290ms	_{p=0.036 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{74ms (± 1.87%)}	_{73ms (± 1.22%)}	_~	_72ms	_74ms	_{p=0.673 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,345ms (± 0.19%)}	_{3,332ms (± 0.43%)}	_~	_3,309ms	_3,349ms	_{p=0.128 n=6}
_{Req 2 - geterr}	_{1,804ms (± 3.77%)}	_{1,866ms (± 5.65%)}	_~	_1,751ms	_1,983ms	_{p=0.378 n=6}
_{Req 3 - references}	_{111ms (± 0.74%)}	_{109ms (± 1.58%)}	_~	_107ms	_111ms	_{p=0.183 n=6}
_{Req 4 - navto}	_{348ms (± 1.34%)}	_{343ms (± 1.21%)}	_~	_337ms	_348ms	_{p=0.169 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,136 (± 0.00%)}	_~	_3,136	_3,136	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{436ms (± 1.40%)}	_{437ms (± 1.39%)}	_~	_426ms	_443ms	_{p=0.936 n=6}
_{Compiler-UnionsTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,578ms (± 0.14%)}	_{2,581ms (± 0.41%)}	_~	_2,565ms	_2,591ms	_{p=0.378 n=6}
_{Req 2 - geterr}	_{6,019ms (± 0.18%)}	_{6,034ms (± 0.51%)}	_~	_5,997ms	_6,089ms	_{p=0.423 n=6}
_{Req 3 - references}	_{367ms (± 0.87%)}	_{365ms (± 0.75%)}	_~	_361ms	_369ms	_{p=0.421 n=6}
_{Req 4 - navto}	_{276ms (± 0.27%)}	_{276ms (± 0.46%)}	_~	_274ms	_278ms	_{p=0.788 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{101ms (± 0.63%)}	_{101ms (± 0.63%)}	_~	_100ms	_102ms	_{p=1.000 n=6}
_{CompilerTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{2,793ms (± 0.75%)}	_{2,811ms (± 0.43%)}	_~	_2,793ms	_2,828ms	_{p=0.173 n=6}
_{Req 2 - geterr}	_{4,566ms (± 2.27%)}	_{4,453ms (± 1.66%)}	_~	_4,393ms	_4,599ms	_{p=0.065 n=6}
_{Req 3 - references}	_{381ms (± 0.68%)}	_{377ms (± 0.57%)}	_{-4ms (- 0.96%)}	_374ms	_380ms	_{p=0.036 n=6}
_{Req 4 - navto}	_{293ms (± 1.28%)}	_{295ms (± 1.05%)}	_~	_289ms	_298ms	_{p=0.571 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{83ms (± 1.27%)}	_{90ms (± 9.73%)}	_{+7ms (+ 8.89%)}	_82ms	_101ms	_{p=0.035 n=6}
_{xstateTSServer - node (v14.15.1, x64)}
_{Req 1 - updateOpen}	_{3,675ms (± 0.30%)}	_{3,665ms (± 0.94%)}	_~	_3,640ms	_3,731ms	_{p=0.173 n=6}
_{Req 2 - geterr}	_{1,837ms (± 0.43%)}	_{1,851ms (± 0.37%)}	_{+14ms (+ 0.75%)}	_1,839ms	_1,858ms	_{p=0.016 n=6}
_{Req 3 - references}	_{126ms (± 2.70%)}	_{127ms (± 3.69%)}	_~	_122ms	_133ms	_{p=0.686 n=6}
_{Req 4 - navto}	_{380ms (± 2.17%)}	_{377ms (± 0.91%)}	_~	_372ms	_381ms	_{p=0.374 n=6}
_{Req 5 - completionInfo count}	_{3,136 (± 0.00%)}	_{3,136 (± 0.00%)}	_~	_3,136	_3,136	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{455ms (± 2.26%)}	_{452ms (± 0.95%)}	_~	_445ms	_456ms	_{p=0.229 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.15.1, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.15.1, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.15.1, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₉₄₉	₆
_Baseline	_main	₆

Startup

Comparison Report - main..52949

_Metric	_main	₅₂₉₄₉	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{142.71ms (± 0.20%)}	_{142.77ms (± 0.21%)}	_{+0.07ms (+ 0.05%)}	_142.13ms	_147.71ms	_{p=0.002 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{227.74ms (± 0.19%)}	_{227.86ms (± 0.19%)}	_{+0.11ms (+ 0.05%)}	_226.74ms	_234.61ms	_{p=0.001 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{229.15ms (± 0.15%)}	_{230.35ms (± 0.30%)}	_{+1.20ms (+ 0.53%)}	_228.46ms	_237.38ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{210.01ms (± 0.18%)}	_{212.02ms (± 0.38%)}	_{+2.01ms (+ 0.96%)}	_209.29ms	_218.50ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-135-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₂₉₄₉	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-02-24T18:00:46Z

@RyanCavanaugh Here are the results of running the top-repos suite comparing main and refs/pull/52949/merge:

Everything looks good!

rbuckton · 2023-02-25T01:08:29Z

This exists because the result for Awaited<null> in strictNullChecks: false is never, when it should be null (or even any, but certainly not never):

TypeScript Playground

rbuckton · 2023-02-25T01:11:03Z

the test suite lacks the appropriate test case

This seems to be the case. We need to add a test for both Awaited<null> and Awaited<undefined> in tests/cases/compiler/awaitedtype.ts and tests/cases/compiler/awaitedTypeStrictNull.ts.

rbuckton · 2023-02-25T01:21:21Z

#52960 adds the missing tests. I have also verified that they do report a baseline change if the T extends null | undefined branch is removed.

Remove the specialcase intended for strictNullChecks: false in `Awa…

7e8f046

…ited`

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Feb 24, 2023

DanielRosenwasser requested a review from rbuckton February 24, 2023 21:07

rbuckton closed this Feb 25, 2023

Andarist deleted the experiment/remove-special-case-in-awaited branch February 25, 2023 06:39

Andarist restored the experiment/remove-special-case-in-awaited branch August 31, 2023 21:48

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Conversation

Andarist commented Feb 24, 2023

Uh oh!

typescript-bot commented Feb 24, 2023

Uh oh!

RyanCavanaugh commented Feb 24, 2023

Uh oh!

typescript-bot commented Feb 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Feb 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 24, 2023

Uh oh!

typescript-bot commented Feb 24, 2023

Compiler

TSServer

Startup

Uh oh!

typescript-bot commented Feb 24, 2023

Uh oh!

rbuckton commented Feb 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rbuckton commented Feb 25, 2023

Uh oh!

rbuckton commented Feb 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

typescript-bot commented Feb 24, 2023 •

edited

Loading

typescript-bot commented Feb 24, 2023 •

edited

Loading

typescript-bot commented Feb 24, 2023 •

edited

Loading

typescript-bot commented Feb 24, 2023 •

edited

Loading

jakebailey commented Feb 24, 2023 •

edited

Loading

typescript-bot commented Feb 24, 2023 •

edited

Loading

rbuckton commented Feb 25, 2023 •

edited

Loading