-
Notifications
You must be signed in to change notification settings - Fork 13.2k
Introduce ES2025 target & Add missing ScriptTargetFeatures #63046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the PR! It looks like you've changed the TSServer protocol in some way. Please ensure that any changes here don't break consumers of the current TSServer API. For some extra review, we'll ping @sheetalkamat, @mjbvz, and @joj for you. Feel free to loop in other consumers/maintainers if necessary. |
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
|
Can we please get this reviewed? I know the country is burning and everyone is being replaced by AI but this would be really useful for those of us who deal with audiences across different languages. |
|
We have a lot of these lib related PRs; it's absolutely our intention to review all of them as soon as we can, we've just had a bunch of other stuff that has been a bit more pressing. |
|
I will note that an all-up PR for this may not be as useful as us reviewing the individual esnext PRs and then having a dedicated ES2025 PR; them being mixed together in this PR is making it hard to figure out what's new and what's just moving around. I would have preferred that the other PRs not be closed and this PR be a pure move + define options. |
|
Only two files were newly added: es2025.intl.d.ts and es2025.regexp.d.ts. I created this combined PR because the individual "esnext" PRs for these features had stalled, and there had been no progress. I wanted to take over the tasks myself, and since there are only two added files, I thought the review would not be too difficult. @jakebailey If you still prefer to have them separated, I can create two individual PRs instead. What do you think? |
Co-authored-by: lionel-rowe <lionel.rowe@gmail.com>
Co-authored-by: 김상두 <puki4416@gmail.com>
9d68792 to
86c687a
Compare
Fixes #61735
Related issues and PRs
ES2025
RegExp.escapeCloses #61321
Closes #62138
ES2025
Intl.DurationFormatCloses #60608
Closes #60646