Skip to content

.NET Workflows - Add unit tests for ConditionGroupExecutor#3893

Open
Copilot wants to merge 8 commits intomainfrom
copilot/add-condition-group-executor-tests
Open

.NET Workflows - Add unit tests for ConditionGroupExecutor#3893
Copilot wants to merge 8 commits intomainfrom
copilot/add-condition-group-executor-tests

Conversation

Copy link
Contributor

Copilot AI commented Feb 12, 2026

Motivation and Context

Unit test coverage for ConditionGroupExecutor was missing. Tests are needed to verify condition evaluation, branching logic, and step naming conventions.

Description

Adds ConditionGroupExecutorTest with 100% line coverage of ConditionGroupExecutor.

Contribution Checklist

  • The code builds clean without any errors or warnings
  • The PR follows the Contribution Guidelines
  • All unit tests pass, and I have added new tests where possible
  • Is this a breaking change? If yes, add "[BREAKING]" prefix to the title of the PR.

Copilot AI and others added 2 commits February 12, 2026 18:53
Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
…comments

Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
Copilot AI changed the title [WIP] Add unit test class for ConditionGroupExecutor Add unit tests for ConditionGroupExecutor Feb 12, 2026
Copilot AI requested a review from crickman February 12, 2026 19:01
@crickman crickman added .NET workflows Related to Workflows in agent-framework declarative-workflow v1.0 Features being tracked for the version 1.0 GA labels Feb 12, 2026
@github-actions github-actions bot changed the title Add unit tests for ConditionGroupExecutor .NET: Add unit tests for ConditionGroupExecutor Feb 12, 2026
@crickman crickman marked this pull request as ready for review February 12, 2026 23:30
Copilot AI review requested due to automatic review settings February 12, 2026 23:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds missing unit test coverage for ConditionGroupExecutor in the declarative workflows object model, and refactors existing tests to reuse a shared IsDiscreteAction assertion helper.

Changes:

  • Add ConditionGroupExecutorTest covering condition evaluation, branching, and step naming.
  • Refactor WorkflowActionExecutorTest/ForeachExecutorTest to centralize IsDiscreteAction verification.
  • Modify ConditionGroupExecutor.Steps.Else behavior (removes the prior fallback name).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/WorkflowActionExecutorTest.cs Adjusts test execution helpers and adds a shared VerifyIsDiscrete assertion.
dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/ForeachExecutorTest.cs Switches inline reflection assertion to the shared VerifyIsDiscrete helper.
dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/ConditionGroupExecutorTest.cs New unit tests for ConditionGroupExecutor behavior and naming conventions.
dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/ObjectModel/ConditionGroupExecutor.cs Changes else-step naming behavior by removing the default fallback.

@crickman crickman changed the title .NET: Add unit tests for ConditionGroupExecutor .NET Workflows - Add unit tests for ConditionGroupExecutor Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

declarative-workflow .NET v1.0 Features being tracked for the version 1.0 GA workflows Related to Workflows in agent-framework

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants