.NET Workflows - Add unit tests for ConditionGroupExecutor#3893
Open
.NET Workflows - Add unit tests for ConditionGroupExecutor#3893
Conversation
Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
…comments Co-authored-by: crickman <66376200+crickman@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add unit test class for ConditionGroupExecutor
Add unit tests for ConditionGroupExecutor
Feb 12, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds missing unit test coverage for ConditionGroupExecutor in the declarative workflows object model, and refactors existing tests to reuse a shared IsDiscreteAction assertion helper.
Changes:
- Add
ConditionGroupExecutorTestcovering condition evaluation, branching, and step naming. - Refactor
WorkflowActionExecutorTest/ForeachExecutorTestto centralizeIsDiscreteActionverification. - Modify
ConditionGroupExecutor.Steps.Elsebehavior (removes the prior fallback name).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/WorkflowActionExecutorTest.cs | Adjusts test execution helpers and adds a shared VerifyIsDiscrete assertion. |
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/ForeachExecutorTest.cs | Switches inline reflection assertion to the shared VerifyIsDiscrete helper. |
| dotnet/tests/Microsoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/ConditionGroupExecutorTest.cs | New unit tests for ConditionGroupExecutor behavior and naming conventions. |
| dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/ObjectModel/ConditionGroupExecutor.cs | Changes else-step naming behavior by removing the default fallback. |
...icrosoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/ConditionGroupExecutorTest.cs
Outdated
Show resolved
Hide resolved
...icrosoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/ConditionGroupExecutorTest.cs
Outdated
Show resolved
Hide resolved
...icrosoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/ConditionGroupExecutorTest.cs
Outdated
Show resolved
Hide resolved
...icrosoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/WorkflowActionExecutorTest.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/ObjectModel/ConditionGroupExecutor.cs
Show resolved
Hide resolved
dotnet/src/Microsoft.Agents.AI.Workflows.Declarative/ObjectModel/ConditionGroupExecutor.cs
Show resolved
Hide resolved
peibekwe
reviewed
Feb 13, 2026
...icrosoft.Agents.AI.Workflows.Declarative.UnitTests/ObjectModel/ConditionGroupExecutorTest.cs
Outdated
Show resolved
Hide resolved
peibekwe
approved these changes
Feb 13, 2026
crickman
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Unit test coverage for
ConditionGroupExecutorwas missing. Tests are needed to verify condition evaluation, branching logic, and step naming conventions.Description
Adds
ConditionGroupExecutorTestwith 100% line coverage ofConditionGroupExecutor.Contribution Checklist