Skip to content

Conversation

@v-aaditya
Copy link
Contributor

@v-aaditya v-aaditya commented Jan 28, 2026

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Patch nodejs18 for CVE-2025-59466

  • Upstream patch has been backported manually.

  • Upstream changes in files src/debug_utils.cc and src/node_report.cc have not been included in the patch because the affected code is not present in our version of nodejs.

  • Some part of upstream changes in file src/node_errors.cc have not been included in the patch as the affected code is not present in our version of nodejs.

  • GetCurrentStackTrace function is added in src/node_errors.cc file for completeness.

  • Upstream Patch Reference - https://github.com/nodejs/node/commit/d7a5c587c0.patch

Build/Dependency Information

The PR is a leaf PR which builds alone successfully.

Change Log
  • modified: SPECS/nodejs/nodejs18.spec
  • new file: SPECS/nodejs/CVE-2025-59466.patch
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology
  • Local build could not be triggered due to resource limitation.

@v-aaditya v-aaditya marked this pull request as ready for review January 28, 2026 06:25
@v-aaditya v-aaditya requested a review from a team as a code owner January 28, 2026 06:25
Copy link
Contributor

@Kanishk-Bansal Kanishk-Bansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-aaditya
Copy link
Contributor Author

Buddy Build

Buddy Build has failed. looking into it.

@v-aaditya
Copy link
Contributor Author

@v-aaditya
Copy link
Contributor Author

Again triggered the Buddy Build - https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1037463&view=results

@Kanishk-Bansal Buddy build is successful now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

main PR Destined for main Packaging security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants