Open
Conversation
MathiasVP
reviewed
Jan 30, 2026
Collaborator
MathiasVP
left a comment
MathiasVP
left a comment
There was a problem hiding this comment.
This looks excellent, @chanel-y! 🚀
A few comments. I think the only one I'd really like to see fixed is the comment on CryptoAlgorithmObjectCreation. The others are mostly just stylistic suggestions which you can ignore if you feel like it.
powershell/ql/src/queries/security/cwe-327/ApprovedCipherMode.ql
Outdated
Show resolved
Hide resolved
powershell/ql/lib/semmle/code/powershell/security/cryptography/CryptographyModule.qll
Outdated
Show resolved
Hide resolved
powershell/ql/lib/semmle/code/powershell/security/cryptography/CryptographyModule.qll
Outdated
Show resolved
Hide resolved
powershell/ql/src/queries/security/cwe-327/ApprovedCipherMode.ql
Outdated
Show resolved
Hide resolved
...shell/ql/test/query-tests/security/cwe-327/WeakSymmetricAlgorithm/WeakSymmetricAlgorithm.ps1
Outdated
Show resolved
Hide resolved
powershell/ql/src/queries/security/cwe-327/ApprovedCipherMode.qhelp
Outdated
Show resolved
Hide resolved
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com>
Co-authored-by: Mathias Vorreiter Pedersen <mathiasvp@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Powershell analogs to existing Microsoft Crypto csharp queries
WeakHashes: looking for usages of weak hashing algorithms like SHA1
SymmetricAlgorithm: looking for usages of weak symmetric algorithms like DES
ObsoleteKDFAlgorithm: looking for usages of the obsolete functions Rfc2898DeriveBytes.CryptDeriveKey and PasswordDeriveBytes.CryptDeriveKey
ApprovedCipherMode: looking for usages of weak block modes like ECB