fix: update VM size defaults and enhance troubleshooting documentation for the same#446
Open
Harsh-Microsoft wants to merge 2 commits intodevfrom
Open
fix: update VM size defaults and enhance troubleshooting documentation for the same#446Harsh-Microsoft wants to merge 2 commits intodevfrom
Harsh-Microsoft wants to merge 2 commits intodevfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request updates the default jumpbox VM size for deployments to use a more modern and broadly available SKU (
Standard_D2s_v5) instead of the legacyStandard_DS2_v2. It also introduces a new environment parameter for customizing the VM size, improves documentation and troubleshooting guidance for VM sizing and related errors, and clarifies which VM sizes are suitable for accelerated networking.Jumpbox VM default and customization improvements:
infra/main.bicepandinfra/main.jsonfromStandard_DS2_v2toStandard_D2s_v5, ensuring deployments use a current-generation VM with better regional availability and performance. [1] [2]AZURE_ENV_VM_SIZEparameter todocs/CustomizingAzdParameters.md,infra/main.waf.parameters.json, and deployment templates, allowing users to easily override the default jumpbox VM size via environment settings. [1] [2]Documentation and troubleshooting enhancements:
docs/TroubleShootingSteps.mdforSkuNotAvailableandVMSizeIsNotPermittedToEnableAcceleratedNetworkingerrors, providing region-specific guidance, recommended VM alternatives, and explicit instructions for using and overriding the jumpbox VM size. [1] [2]infra/modules/virtualNetwork.bicepto recommend modern D-series SKUs (v5/v4), clarify legacy SKU status, and warn against A-series and B-series VMs for jumpbox deployments.Template and dependency fixes:
infra/main.jsonto ensure proper deployment sequencing.infra/main.jsonto reflect the new template changes.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information