-
Notifications
You must be signed in to change notification settings - Fork 82
Remove Azure SQL Edge support (retiring Sept 30, 2025) #680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes Azure SQL Edge support from go-sqlcmd in response to the product's retirement scheduled for September 30, 2025. The changes eliminate the azsql-edge command and all associated functionality while preserving SQL Server support.
Changes:
- Removed Edge command registration from install.go and deleted all Azure SQL Edge related files (edge.go, edge_test.go, and edge/ subdirectory)
- Updated documentation (README.md and .github/copilot-instructions.md) to remove Azure SQL Edge references
- Regenerated translation catalog files to remove Azure SQL Edge strings
- Updated uninstall_test.go to use Mssql instead of Edge for testing
Reviewed changes
Copilot reviewed 19 out of 21 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/modern/root/install.go | Removed Edge command from SubCommands list |
| cmd/modern/root/install/edge.go | Deleted entire Edge command implementation |
| cmd/modern/root/install/edge_test.go | Deleted Edge installation tests |
| cmd/modern/root/install/edge/get-tags.go | Deleted Edge tag retrieval command |
| cmd/modern/root/install/edge/get-tags_test.go | Deleted Edge tag retrieval tests |
| cmd/modern/root/uninstall_test.go | Changed test from Edge to Mssql |
| README.md | Removed Azure SQL Edge references from documentation |
| .github/copilot-instructions.md | Removed Azure SQL Edge from container support documentation |
| internal/translations/locales/*/out.gotext.json | Regenerated translation catalogs to remove Azure SQL Edge strings |
|
@copilot please address the review feedback |
…only Azure SQL Edge entries Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
The review feedback has already been fully addressed in commit 5bb18f6. All translation files now:
The |
|
@copilot as you resolve the review items you should mark them resolved. |
I don't have the capability to mark GitHub PR review comments as resolved through the available tools. The review comments were addressed in commit 5bb18f6, which fixed the translation catalog issues by preserving Windows-specific strings while removing only Azure SQL Edge entries. To mark the comments as resolved, you or another reviewer with access would need to do so through the GitHub PR interface. All the technical issues raised in those comments have been fixed and verified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 19 out of 21 changed files in this pull request and generated no new comments.
|
@copilot why did NOTICE.md get changed? That file is built from the build scripts based on the licenses of packages referenced by go.mod |
Co-authored-by: shueybubbles <2224906+shueybubbles@users.noreply.github.com>
You're correct - NOTICE.md is a generated file and shouldn't have been modified. It was accidentally truncated during development when build scripts were run. Fixed in commit 53a0c5c by restoring it to its original state. The file will be properly regenerated by the build process when needed. |
Summary: Remove Azure SQL Edge Support
Azure SQL Edge is being retired on September 30, 2025. This PR completely removes Azure SQL Edge support from sqlcmd.
Changes Made:
Verification:
✓
sqlcmd create --helpnow only showsmssqlcommand✓ All unit tests pass including install, uninstall, and root package tests
✓ Binary builds successfully
✓ No Azure SQL Edge references remain in code or translations
✓ Windows-specific strings (Press Ctrl+C, credential manager messages) are preserved
✓ NOTICE.md restored to its original state (generated file should not be manually modified)
Translation Catalog Fix:
The previous translation regeneration inadvertently removed Windows-specific strings because gotext running on Linux doesn't scan
*_windows.gofiles. This was fixed by:NOTICE.md Restoration:
NOTICE.md is a generated file created by the build scripts based on go.mod dependencies. It was accidentally truncated during development but has now been restored to its original state. This file should be regenerated by the build process when needed.
Security Summary:
No security vulnerabilities were found during the CodeQL security scan.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.