Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 31, 2026

Summary: Remove Azure SQL Edge Support

Azure SQL Edge is being retired on September 30, 2025. This PR completely removes Azure SQL Edge support from sqlcmd.

Changes Made:

  • Remove Edge command registration from install.go
  • Delete edge.go, edge_test.go files in cmd/modern/root/install/
  • Delete edge/ subdirectory with get-tags.go and get-tags_test.go
  • Update README.md to remove Azure SQL Edge references
  • Update .github/copilot-instructions.md to remove Azure SQL Edge references
  • Fix translation catalog: Remove only Azure SQL Edge strings while preserving Windows-specific strings
  • Fix uninstall_test.go that was using install.Edge instead of Mssql
  • Restore NOTICE.md (generated file that was accidentally modified)
  • All tests pass ✓
  • Build successful ✓
  • Code review complete - issues addressed ✓
  • Security scan complete - no vulnerabilities ✓

Verification:

sqlcmd create --help now only shows mssql command
✓ All unit tests pass including install, uninstall, and root package tests
✓ Binary builds successfully
✓ No Azure SQL Edge references remain in code or translations
✓ Windows-specific strings (Press Ctrl+C, credential manager messages) are preserved
✓ NOTICE.md restored to its original state (generated file should not be manually modified)

Translation Catalog Fix:

The previous translation regeneration inadvertently removed Windows-specific strings because gotext running on Linux doesn't scan *_windows.go files. This was fixed by:

  • Restoring the translation JSON files to original state
  • Manually removing only the 3 Azure SQL Edge entries from each locale
  • Manually adding back the 3 Windows-specific entries that are still in use
  • Regenerating catalog.go with GOOS=windows to include Windows-only strings

NOTICE.md Restoration:

NOTICE.md is a generated file created by the build scripts based on go.mod dependencies. It was accidentally truncated during development but has now been restored to its original state. This file should be regenerated by the build process when needed.

Security Summary:

No security vulnerabilities were found during the CodeQL security scan.

Original prompt

This section details on the original issue you should resolve

<issue_title>Remove SQL Edge from sqlcmd create options since SQL Edge is being retired</issue_title>
<issue_description>Azure SQL Edge will be officially retired Sept 30, 2025. We should remove it as an option in sqlcmd create</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits January 31, 2026 19:48
Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
@dlevy-msft-sql dlevy-msft-sql added documentation Improvements or additions to documentation sqlcmd switch switch in existing sqlcmd Size: S Small issue (less than one week effort) housekeeping in-review labels Jan 31, 2026
Copilot AI changed the title [WIP] Remove SQL Edge from sqlcmd create options Remove Azure SQL Edge support (retiring Sept 30, 2025) Jan 31, 2026
Copilot AI requested a review from dlevy-msft-sql January 31, 2026 19:55
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes Azure SQL Edge support from go-sqlcmd in response to the product's retirement scheduled for September 30, 2025. The changes eliminate the azsql-edge command and all associated functionality while preserving SQL Server support.

Changes:

  • Removed Edge command registration from install.go and deleted all Azure SQL Edge related files (edge.go, edge_test.go, and edge/ subdirectory)
  • Updated documentation (README.md and .github/copilot-instructions.md) to remove Azure SQL Edge references
  • Regenerated translation catalog files to remove Azure SQL Edge strings
  • Updated uninstall_test.go to use Mssql instead of Edge for testing

Reviewed changes

Copilot reviewed 19 out of 21 changed files in this pull request and generated 11 comments.

Show a summary per file
File Description
cmd/modern/root/install.go Removed Edge command from SubCommands list
cmd/modern/root/install/edge.go Deleted entire Edge command implementation
cmd/modern/root/install/edge_test.go Deleted Edge installation tests
cmd/modern/root/install/edge/get-tags.go Deleted Edge tag retrieval command
cmd/modern/root/install/edge/get-tags_test.go Deleted Edge tag retrieval tests
cmd/modern/root/uninstall_test.go Changed test from Edge to Mssql
README.md Removed Azure SQL Edge references from documentation
.github/copilot-instructions.md Removed Azure SQL Edge from container support documentation
internal/translations/locales/*/out.gotext.json Regenerated translation catalogs to remove Azure SQL Edge strings

@dlevy-msft-sql
Copy link
Contributor

@copilot please address the review feedback

…only Azure SQL Edge entries

Co-authored-by: dlevy-msft-sql <194277063+dlevy-msft-sql@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 31, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • does
    • Triggering command: /tmp/go-build3424399543/b001/install.test /tmp/go-build3424399543/b001/install.test -test.testlogfile=/tmp/go-build3424399543/b001/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.v=true --noprofile ache/go/1.24.12/-compiler=gc ux_amd64/compile -e oot}} {{.Goroot}-atomic x64/bin/go ux_amd64/compile-buildtags list�� /locafero@v0.11.-errorsas /locafero@v0.11.-ifaceassert x64/pkg/tool/lin-nilfunc -installsuffix= oot}} {{.Goroot}-atomic -- x64/pkg/tool/lin-buildtags (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copy link
Contributor Author

Copilot AI commented Jan 31, 2026

@copilot please address the review feedback

The review feedback has already been fully addressed in commit 5bb18f6. All translation files now:

  • ✅ Preserve Windows-specific strings (Press Ctrl+C, credential manager messages)
  • ✅ Remove only Azure SQL Edge entries
  • ✅ Build successfully with no errors
  • ✅ All tests pass

The azsql-edge command has been completely removed from sqlcmd create.

@dlevy-msft-sql
Copy link
Contributor

@copilot as you resolve the review items you should mark them resolved.

Copy link
Contributor Author

Copilot AI commented Jan 31, 2026

@copilot as you resolve the review items you should mark them resolved.

I don't have the capability to mark GitHub PR review comments as resolved through the available tools. The review comments were addressed in commit 5bb18f6, which fixed the translation catalog issues by preserving Windows-specific strings while removing only Azure SQL Edge entries.

To mark the comments as resolved, you or another reviewer with access would need to do so through the GitHub PR interface. All the technical issues raised in those comments have been fixed and verified.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 21 changed files in this pull request and generated no new comments.

@dlevy-msft-sql dlevy-msft-sql marked this pull request as ready for review January 31, 2026 20:31
@shueybubbles
Copy link
Collaborator

@copilot why did NOTICE.md get changed? That file is built from the build scripts based on the licenses of packages referenced by go.mod

Co-authored-by: shueybubbles <2224906+shueybubbles@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 1, 2026

@copilot why did NOTICE.md get changed? That file is built from the build scripts based on the licenses of packages referenced by go.mod

You're correct - NOTICE.md is a generated file and shouldn't have been modified. It was accidentally truncated during development when build scripts were run. Fixed in commit 53a0c5c by restoring it to its original state. The file will be properly regenerated by the build process when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation housekeeping in-review Size: S Small issue (less than one week effort) sqlcmd switch switch in existing sqlcmd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove SQL Edge from sqlcmd create options since SQL Edge is being retired

3 participants