Fix sqlcmd hanging for ~10 minutes after query timeout on Linux #682
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, sqlcmd with
-tflag correctly prints "Timeout expired" but hangs for ~10 minutes before exiting. Works correctly on Windows.Root Cause
runQuery()never closes thesql.Rowsobject returned byQueryContext(). On timeout, the connection remains open. Linux TCP stack waits ~10 minutes for cleanup; Windows cleans up more aggressively.Changes
Added missing
defer rows.Close()immediately afterQueryContext():This releases the connection immediately when the function returns, regardless of error or timeout conditions.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.