Skip to content

fix alarm#729

Merged
CvvT merged 1 commit intomainfrom
weiteng/fix_alarm_on_windows
Mar 14, 2026
Merged

fix alarm#729
CvvT merged 1 commit intomainfrom
weiteng/fix_alarm_on_windows

Conversation

@CvvT
Copy link
Contributor

@CvvT CvvT commented Mar 14, 2026

The test test_alarm_fires_after_deadline may fail on Windows because of imprecision of timer: from the log https://github.com/microsoft/litebox/actions/runs/23078466441/job/67043130079, signal is delivered 1ms earlier than expected and thus the remaining time rounds up to 1s. Reset alarm deadline to fix this issue.

@CvvT CvvT marked this pull request as ready for review March 14, 2026 03:07
@github-actions
Copy link

🤖 SemverChecks 🤖 No breaking API changes detected

Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered.

@CvvT CvvT added this pull request to the merge queue Mar 14, 2026
Merged via the queue into main with commit d26a1b5 Mar 14, 2026
14 checks passed
@CvvT CvvT deleted the weiteng/fix_alarm_on_windows branch March 14, 2026 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants