pytestadapter: Read pipe in non-blocking mode so tests don't hang if the subprocess fails to open the pipe for writing.#25725
Open
garyvdm wants to merge 3 commits intomicrosoft:mainfrom
Open
Conversation
Author
|
@microsoft-github-policy-service agree |
…ipe code encapuslated.
…the subprocess fails to open the pipe for writing.
garyvdm
force-pushed
the
test_non_block_io
branch
from
999c9f6 to
31e861a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the pytest adapter tests, if subprocess fails to open the pipe for writing, then the the open call for reading the pipe blocks, and the tests hang. This PR fixes that by using non-blocking IO when reading the pipe. This should make debugging the tests easier.
This also address 2 other minor issues: