Faster TextTemplateParser [Chrome] #238
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was playing with RegEx so i tried to come up with a RegEx way of handeling the TextTemplate in Rivets. And (at least in Chrome) the solution is nearly twice as fast. You can find the perf test here: http://jsperf.com/parse-string-regex It’s is quite astonishing how much better V8 can handel regular expressions.
Contributor
|
It would also be faster to cache the regex that has once been compiled. |
Owner
|
@FWeinb Thanks for the pull request. Seems like Safari 7 is still behind with this, the "Parse by Hand" code runs much faster in Safari, but the "Simple Regex II" runs even faster in Chrome. Tough decision to merge this, will keep it open for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing with RegEx so i tried to come up with a RegEx way of
handling the TextTemplate in Rivets. And (at least in Chrome) the
solution is nearly twice as fast.
You can find the perf test here: http://jsperf.com/parse-string-regex
It’s is quite astonishing how much better V8 can handle regular
expressions.
If other browser catch up with the RegEx performance this could be a better solution.