Skip to content

Improve error message for non-existent database #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucas-koontz merged 2 commits into from
Feb 12, 2026
Merged

Improve error message for non-existent database #218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
868428e
Improve error message for non-existent database
lucas-koontz Feb 12, 2026
fc594aa
Merge branch 'main' into lucas-koontz-patch-1
lucas-koontz Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mindsdb_sdk/databases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ def get(self, name: str) -> Database:
"""
databases = self._list_databases()
if name not in databases:
raise AttributeError("Database doesn't exist")
raise AttributeError(f"Database '{name}' doesn't exist")
return databases[name]
Comment on lines 174 to 178
Copy link

@entelligence-ai-pr-reviews entelligence-ai-pr-reviews bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate Code: ⚠️ Duplicate Code Detected (Similarity: 92%)

This function Databases.get duplicates existing code.

📍 Original Location:

mindsdb_sdk/projects.py:152-161

Function: Projects.get

💡 Recommendation:
Extract this pattern into a template method in the CollectionBase parent class:

class CollectionBase:
    def _get_with_validation(self, name: str, list_method, constructor, resource_type: str):
        """Template method for validated get operations"""
        items = list_method()
        if name not in items:
            raise AttributeError(f"{resource_type} '{name}' doesn't exist")
        return constructor(name, items) if callable(constructor) else items[name]

Then both Databases.get() and Projects.get() can call this template method, reducing duplication and ensuring consistent error messages across all collection managers.

Consider importing and reusing the existing function instead of duplicating the logic.


def update(self, name: str, connection_args: Dict) -> Database:
Expand Down