Redact sensitive query params in HTTP error messages #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
redact_url_query()static helper function that replaces query parameter values with[redacted]while preserving parameter names, separators, and URL structurehttp_request::perform()methods to redact URLs before including them in error outputThis prevents sensitive tokens or credentials in query parameters from leaking into error messages/exceptions.
Example
Before:
After:
Notes
lib/playapi/util/http.cppis modified (no unrelated file changes)printfstatements (guarded by#ifndef NDEBUG) are left unchanged per the issue scope, as they are already disabled by default in release buildsAddresses the same problem described in #3.