Convert event offset to int, avoiding overflow with i32#13614
Open
barakugav wants to merge 1 commit intomne-tools:mainfrom
Open
Convert event offset to int, avoiding overflow with i32#13614barakugav wants to merge 1 commit intomne-tools:mainfrom
barakugav wants to merge 1 commit intomne-tools:mainfrom
Conversation
Member
|
This is also in progress at #13548, can you see if that PR fixes your problem? |
Author
Seems like it does, yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
The function
_compute_robust_event_table_positionread the offset of the event tables. Since numpy 2.x.y, the following line returnsnp.int32rather than pythonicint:This causes an overflow in other places, such as
Additional information