Skip to content

[Server] Add autoload check for enum types in ReferenceHandler #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joshuatam wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

[Server] Add autoload check for enum types in ReferenceHandler #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Capability/Registry/ReferenceHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,9 @@ private function castArgumentType(mixed $argument, \ReflectionParameter $paramet

$typeName = $type->getName();

if (enum_exists($typeName)) {
$shouldAutoload = !in_array($typeName, ['int', 'float', 'string', 'bool', 'array', 'object', 'callable', 'iterable', 'mixed', 'void', 'null', 'false', 'true', 'never']);

if (enum_exists($typeName, $shouldAutoload)) {
Comment on lines +176 to +178
Copy link
Contributor

@Nyholm Nyholm Feb 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do something like this?

Ie, if it is an int, we would never call enum_exists().

Suggested change
$shouldAutoload = !in_array($typeName, ['int', 'float', 'string', 'bool', 'array', 'object', 'callable', 'iterable', 'mixed', 'void', 'null', 'false', 'true', 'never']);
if (enum_exists($typeName, $shouldAutoload)) {
if ($type->isBuiltin() === false && enum_exists($typeName)) {

https://www.php.net/manual/en/language.types.type-system.php

if (\is_object($argument) && $argument instanceof $typeName) {
return $argument;
}
Expand Down
Loading