Open
Conversation
This task re-processes the upstream source file and adds missing zip codes to the yml in the gem. It is an add-only process and does not modify or remove any conflicting data. Also fixed a quoting mistake in the string parsing of existing convert task.
Rake task picks up several new zip codes. It appears the default quoting of yaml changed since US.yml was originally saved and now entries with a leading-zero are quoted where they weren't previously.
Author
|
@brodyhoskins is there any interest at all in the rake task in this PR, or should I give up on that and submit PRs for individual missing zip codes instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We keep running into missing zip codes and I noticed the list of PRs to manually add things one at a time seems like a lot of maintainer overhead.
This task lets you download the latest upstream file and incorporate all new zip codes in one shot. This could be extended to also download the upstream file automatically, but I did not include that because I wanted to mirror the behavior of the existing rake task. If you'd like me to add that I'm happy to.
Whether we can get this merged or not, though, it'd be great if we could cut a new gem version that includes all the added zip codes.
Thanks! This gem has been tremendously useful for us.