feat(settings): add passwordless otp ui#20104
Conversation
StaberindeZA
force-pushed
the
fxa-13017-frontend-otp
branch
2 times, most recently
from
11bd7a8 to
9f206b5
Compare
| getClientId(): string | undefined { | ||
| return this.opts?.clientId || undefined; | ||
| } |
There was a problem hiding this comment.
Reason for this change is so that a clientId can be sent to the passwordless routes in auth-server, which check if passwordless OTP is enabled for specific clientIds.
| return; | ||
| } | ||
|
|
||
| if (isSignup) { |
There was a problem hiding this comment.
I noticed different behavior depending on whether its sign up or sign in, so I mostly copied the logic from Signin/index.tsx and Signup/index.tsx
| default: /^$/, | ||
| env: 'PASSWORDLESS_FORCED_EMAIL_REGEX', | ||
| }, | ||
| allowedClientIds: { |
There was a problem hiding this comment.
Ross mentioned that they wanted to roll this out to settings first, so we might need to update this to support that, not sure how but we can file a follow up.
There was a problem hiding this comment.
My intention with the change to the web-integration, mentioned in this comment, was to enable this.
My assumption is that clientId is undefined for fxa-settings, so the change to web-integration updates that logic, so that it returns the FxA Settings clientId instead. Would this work?
| const wantsKeys = integration.wantsKeys(); | ||
| const isOAuth = isOAuthWebIntegration(integration); | ||
|
|
||
| // Passwordless eligibility: |
packages/fxa-settings/src/pages/Signin/SigninPasswordlessCode/index.tsx
Outdated
Show resolved
Hide resolved
| } | ||
| } else { | ||
| const isFullyVerified = | ||
| result.verified && result.verified; |
There was a problem hiding this comment.
Ah, this was temporary. I copied this from the password signin page which had sessionVerified and I wasn't sure what that was exactly. I had a quick look and doesn't seem its applicable to passwordless otp?
packages/fxa-settings/src/pages/Signin/SigninPasswordlessCode/en.ftl
Outdated
Show resolved
Hide resolved
packages/fxa-settings/src/pages/Signin/SigninPasswordlessCode/index.tsx
Outdated
Show resolved
Hide resolved
StaberindeZA
force-pushed
the
fxa-13017-frontend-otp
branch
from
1b1e561 to
f73a849
Compare
Because: - The passwordless otp signup/signin needs its own pages that vary slightly from existing signin flows. This commit: - Adds signin and signup pages, containers and components Closes #FXA-13017
StaberindeZA
force-pushed
the
fxa-13017-frontend-otp
branch
from
f73a849 to
b759e8e
Compare
2 participants
Because
This pull request
Issue that this pull request solves
Closes: #FXA-13017
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.