bug(settings,auth): Password reset flow breaks after entering invalid ARK#20113
Draft
bug(settings,auth): Password reset flow breaks after entering invalid ARK#20113
Conversation
dschom
force-pushed
the
worktree-FXA-13162
branch
2 times, most recently
from
2253566 to
8defcf6
Compare
… ARK Because: - When a user provides an invalid account recovery key, the flow would break. - At this point, the password reset token has been exchanged and was no longer valid This Commit: - Allows auth endpoints to accept a password forgot token or account reset token - Passes the account reset token as 'token' in location state - Introduces the 'kind' field, to signal if token is a account reset or password forgot token. - Cleans up some cruft in auth client - Brings account reset token and password forgot into alignment (same shape)
dschom
force-pushed
the
worktree-FXA-13162
branch
from
8defcf6 to
06820c7
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Pushing up early. New functional tests pass! But still tinkering with some existing test cases. Feel free to give preliminary review.