feat: add pagination integration tests, fix backward pagination bug

[shrugs]

closes #1622

Summary

• added reusable pagination integration tests across all domain connection fields (Query.domains, Domain.subdomains, Account.domains, Registry.domains) covering all 6 ordering permutations × forward/backward pagination
• fixed backward pagination bug in cursorFilter — removed the effectiveDesc parameter and derived direction comparison directly from queryOrderDir, which was incorrect when inverted flipped the sort
• extracted shared pagination queries, types, and a generic testDomainPagination test harness into reusable test utilities

---

Why

• backward pagination was broken for certain order/direction combos due to effectiveDesc being passed through from the caller (which accounted for inverted) while cursorFilter only needs the declared queryOrderDir
• no integration test coverage existed for pagination or ordering correctness

---

Testing

• all tests run against the devnet via the existing integration test setup
• tests paginate with page size 2 to force multiple pages, then assert ordering correctness and that forward/backward collection yields identical results

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2f59e12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments

Project	Deployment	Actions	Updated (UTC)
admin.ensnode.io	Skipped		Feb 26, 2026 11:30pm
ensnode.io	Skipped		Feb 26, 2026 11:30pm
ensrainbow.io	Skipped		Feb 26, 2026 11:30pm

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/additional-integration-tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Greptile Summary

Fixed critical backward pagination bug where cursorFilter incorrectly used effectiveDesc (includes Relay's inverted XOR) instead of raw queryOrderDir for comparison operator selection. Added comprehensive integration tests covering all 6 ordering permutations (3 orderBy × 2 directions) with both forward and backward pagination for Query.domains, Domain.subdomains, Account.domains, and Registry.domains.

Key Changes:

• Fixed cursor filter logic to use queryOrderDir === "DESC" instead of effectiveDesc for determining comparison operators
• This ensures backward pagination (last/before) correctly selects rows before the cursor, not after it
• Added reusable testDomainPagination helper that validates ordering correctness and forward/backward pagination equivalence
• Tests verify that backward pagination yields identical results to forward pagination for all ordering permutations

Confidence Score: 5/5

• This PR is safe to merge - fixes a critical pagination bug with comprehensive test coverage
• The bug fix is well-reasoned and correct, addressing the root cause of backward pagination selecting wrong rows. Comprehensive integration tests now cover all pagination scenarios, ensuring the fix works properly. Only minor style suggestion about async describe pattern.
• No files require special attention

Important Files Changed

Filename	Overview
apps/ensapi/src/graphql-api/lib/find-domains/find-domains-resolver-helpers.ts	Fixed cursor filter to use raw orderDir instead of effectiveDesc for comparison operator selection
apps/ensapi/src/graphql-api/lib/find-domains/find-domains-resolver.ts	Removed effectiveDesc calculation and parameter passing to cursorFilter calls
apps/ensapi/src/test/integration/test-domain-pagination.ts	Added comprehensive pagination test helper covering 6 ordering permutations with forward/backward iteration

_{Last reviewed commit: 80c55d4}

[greptile-apps]

_{9 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[Copilot]

Pull request overview

Adds a reusable integration test suite to validate Relay-style forward/backward pagination across multiple domain connection fields, and updates the findDomains keyset cursor filtering logic intended to fix a backward-pagination (last/before) bug.

Changes:

• Introduce generic testDomainPagination() helper plus shared pagination GraphQL queries/fragments.
• Expand integration tests for Query.domains, Domain.subdomains, Account.domains, and Registry.domains to cover all order permutations and both pagination directions.
• Modify findDomains cursor filtering and resolver wiring related to effective ordering during inverted (backward) pagination.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
apps/ensapi/src/test/integration/test-domain-pagination.ts	New shared integration test helper to iterate forward/backward through domain connections and assert ordering.
apps/ensapi/src/test/integration/graphql-utils.ts	Extends GraphQLConnection test type to include cursor + pageInfo.
apps/ensapi/src/test/integration/domain-pagination-queries.ts	New shared GraphQL queries/fragments for paginated domain connections.
apps/ensapi/src/graphql-api/schema/query.integration.test.ts	Adds Query.domains pagination integration coverage using the new helper.
apps/ensapi/src/graphql-api/schema/domain.integration.test.ts	Adds Domain.subdomains pagination integration coverage using the new helper.
apps/ensapi/src/graphql-api/schema/account.integration.test.ts	Adds Account.domains pagination integration coverage using the new helper.
apps/ensapi/src/graphql-api/schema/registry.integration.test.ts	Adds Registry.domains pagination integration coverage using the new helper.
apps/ensapi/src/graphql-api/lib/find-domains/find-domains-resolver.ts	Updates resolver cursor filtering calls as part of the backward pagination fix.
apps/ensapi/src/graphql-api/lib/find-domains/find-domains-resolver-helpers.ts	Updates cursorFilter comparison-operator selection logic for keyset pagination.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[lightwalker-eth]

@shrugs Also looks great 👍