feat: migrate ssh config resolver and stop tracking pretty binary#7
Merged
feat: migrate ssh config resolver and stop tracking pretty binary#7
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7 +/- ##
==========================================
+ Coverage 50.42% 50.62% +0.20%
==========================================
Files 18 18
Lines 1178 1193 +15
==========================================
+ Hits 594 604 +10
- Misses 506 509 +3
- Partials 78 80 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ncode
added a commit
that referenced
this pull request
Feb 7, 2026
feat: migrate ssh config resolver and stop tracking pretty binary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to SSH config resolution, ensuring full compatibility with OpenSSH-style
HostandMatchevaluation. It replaces the previous SSH config library with a fork that supports advanced parsing, updates the resolution logic to use this new library, and adds tests to verify correct behavior withMatchblocks. These changes make host resolution more accurate and robust.SSH config resolution improvements:
github.com/kevinburke/ssh_configtogithub.com/ncode/ssh_configingo.modandinternal/sshConn/config.go, enabling OpenSSH-styleHostandMatchevaluation for more accurate host resolution. [1] [2]SSHConfigResolverlogic ininternal/sshConn/config.goto use the new library'sResolvemethod, ensuring proper handling ofHostandMatchblocks and explicit overrides. [1] [2]resolvehelper function to centralize SSH config resolution and context handling.Testing enhancements:
internal/sshConn/config_test.goto verify correct application ofMatchblocks, non-matching blocks, and explicit overrides during host resolution.Documentation update:
README.mdto clarify that host resolution now follows OpenSSH-styleHostandMatchevaluation.