Fix list_filter when cmake version > 3.5.9#62
Merged
BurningEnlightenment merged 3 commits intoned14:masterfrom May 19, 2025
Merged
Fix list_filter when cmake version > 3.5.9#62BurningEnlightenment merged 3 commits intoned14:masterfrom
BurningEnlightenment merged 3 commits intoned14:masterfrom
Conversation
7 tasks
BurningEnlightenment
requested changes
May 14, 2025
cmakelib/QuickCppLibUtils.cmake
Outdated
Comment on lines
56
to
58
| if(CMAKE_VERSION VERSION_GREATER 3.59) | ||
| list(FILTER ${ARGV}) | ||
| set(${listname} ${${listname}} PARENT_SCOPE) |
Collaborator
There was a problem hiding this comment.
Good catch!
However, I suspect that a “.” is missing in the version check, i.e. it should probably have said:
- if(CMAKE_VERSION VERSION_GREATER 3.59)
+ if(CMAKE_VERSION VERSION_GREATER 3.5.9)Given that we already require CMake version 3.9, we might as well completely nuke the else() part and add a deprecation comment to the function.
Author
There was a problem hiding this comment.
As you said, now we required CMake version 3.9, how about just use list(FILTER ${ARGV}) and set PARENT_SCOPE in this function since the else part will never be reached?
Collaborator
There was a problem hiding this comment.
@JackBoosY yes, that's what I tried to suggest 👍
Owner
There was a problem hiding this comment.
I'm okay with removing the older cmake polyfill entirely.
JackBoosY
changed the title
BurningEnlightenment
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we use CMake > 3.59, in
list_filter, the filtered values are not stored since we don't set them in PARENT_SCOPE.Related: microsoft/vcpkg#45231