Fix queue page badge warning for badgeless conventions (#10183)#11188
Merged
Fix queue page badge warning for badgeless conventions (#10183)#11188
Conversation
The queue page was incorrectly showing a "no badge" warning even when the convention was set to "Convention does not sell badges" (ticket_mode: disabled). This fix adds a check for the convention's ticket_mode in the NextRoundInfoBox component. When ticket_mode is 'disabled', the component now treats the ticket status as 'ok' and suppresses the warning message. Changes: - Added ticket_mode field to MySignupQueue GraphQL query - Updated NextRoundInfoBox to check ticket_mode before showing warning - Warning only displays when convention requires tickets Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10183 - Queue page was incorrectly displaying a badge warning even when the convention was configured as badgeless (ticket_mode: disabled).
Changes
ticket_modefield to theMySignupQueueGraphQL queryNextRoundInfoBoxcomponent to check the convention'sticket_modebefore displaying the "no ticket" warningticket_modeisdisabled, the component now returns 'ok' status and suppresses the warningBehavior
Before
After
Test plan
ticket_modeis set todisabled(badgeless)ticket_modeisrequired_for_signupticket_modeisticket_per_event🤖 Generated with Claude Code