Skip to content

Fix queue page badge warning for badgeless conventions (#10183)#11188

Merged
nbudin merged 1 commit intomainfrom
fix-10183-queue-badge-warning-badgeless
Feb 14, 2026
Merged

Fix queue page badge warning for badgeless conventions (#10183)#11188
nbudin merged 1 commit intomainfrom
fix-10183-queue-badge-warning-badgeless

Conversation

@nbudin
Copy link
Contributor

@nbudin nbudin commented Feb 14, 2026

Summary

Fixes #10183 - Queue page was incorrectly displaying a badge warning even when the convention was configured as badgeless (ticket_mode: disabled).

Changes

  • Added ticket_mode field to the MySignupQueue GraphQL query
  • Updated NextRoundInfoBox component to check the convention's ticket_mode before displaying the "no ticket" warning
  • When ticket_mode is disabled, the component now returns 'ok' status and suppresses the warning

Behavior

Before

  • Badgeless conventions would show: "You do not have a badge. You will not be able to sign up for games until you have purchased a badge."
  • This was confusing since the convention doesn't sell badges

After

  • Badgeless conventions no longer show the warning
  • Conventions that require tickets still show the warning appropriately
  • Users in badgeless conventions see the normal info box without any badge-related warnings

Test plan

  • Test with a convention where ticket_mode is set to disabled (badgeless)
    • Navigate to the signup queue page
    • Verify no badge warning is displayed
  • Test with a convention where ticket_mode is required_for_signup
    • Navigate to the signup queue page without a ticket
    • Verify the badge warning is still displayed correctly
  • Test with a convention where ticket_mode is ticket_per_event
    • Verify appropriate behavior for this mode

🤖 Generated with Claude Code

The queue page was incorrectly showing a "no badge" warning even when
the convention was set to "Convention does not sell badges" (ticket_mode: disabled).

This fix adds a check for the convention's ticket_mode in the NextRoundInfoBox
component. When ticket_mode is 'disabled', the component now treats the ticket
status as 'ok' and suppresses the warning message.

Changes:
- Added ticket_mode field to MySignupQueue GraphQL query
- Updated NextRoundInfoBox to check ticket_mode before showing warning
- Warning only displays when convention requires tickets

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@nbudin nbudin added bug patch Bumps the patch version number on release labels Feb 14, 2026
@github-actions
Copy link
Contributor

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
Overall Coverage 🟢 56.5% 🟢 56.5% ⚪ 0%

Minimum allowed coverage is 0%, this run produced 56.5%

@nbudin nbudin merged commit 73edbfb into main Feb 14, 2026
17 checks passed
@nbudin nbudin deleted the fix-10183-queue-badge-warning-badgeless branch February 14, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug patch Bumps the patch version number on release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Queue page badge warning when convention set to badgeless

1 participant