fix(auto-upload): file detection #16459
Open
+236
−139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
force-pushed
the
fix/auto-upload-file-detection
branch
from
543535b to
7a8e90a
Compare
4 tasks
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
fix/auto-upload-file-detection
branch
from
a15d1c4 to
32927bf
Compare
4 tasks
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16459.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The upload operation only requires read access to the file channel. Exclusive locking is unnecessary and can cause
LOCK_FAILEDerrors when multiple uploads are triggered for the same local path. This change allows concurrent read access.When a local file is detected as not eligible for auto-upload, both the auto-upload entity and the corresponding upload entity are removed from the database before continuing.
The upload file operation uses a remote existence check to determine whether a sync conflict has occurred. However, this approach is not accurate when the exact same file already exists on the remote; in such cases, there is no need to block the upload or throw an errors.
How to reproduce?
LOCK_FAILEDerror.