Fix subPath on datadir mounts (fixes #531)#538
Open
Deaddy wants to merge 7 commits intonextcloud:mainfrom
Open
Fix subPath on datadir mounts (fixes #531)#538Deaddy wants to merge 7 commits intonextcloud:mainfrom
Deaddy wants to merge 7 commits intonextcloud:mainfrom
Conversation
- subPath now does not necessarily end on /data, in particular empty subPath possible for datadir on specific PVC - datadir persistence now does not depend on overall persistence anymore - bump .minor because old installs will need to add `/data` back to the subPath in the values file Signed-off-by: Marcel Wunderlich <wunderlich@uni-muenster.de>
Signed-off-by: Marcel Wunderlich <m_wund01@uni-muenster.de>
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
I think an alternative that doesn't require a breaking change would be to add another value that specifies the path of the data folder inside the subpath and if that is empty it is just omitted.
Signed-off-by: Marcel Wunderlich <wunderlich@uni-muenster.de>
Signed-off-by: Marcel Wunderlich <m_wund01@uni-muenster.de>
Signed-off-by: Marcel Wunderlich <m_wund01@uni-muenster.de>
Signed-off-by: Jesse Hitch <jessebot@linux.com>
Signed-off-by: Jesse Hitch <jessebot@linux.com>
jessebot
added
the
Persistence
wrenix
requested changes
Sep 12, 2024
| mountPath: {{ .Values.nextcloud.datadir }} | ||
| subPath: {{ ternary "data" (printf "%s/data" .Values.persistence.nextcloudData.subPath) (empty .Values.persistence.nextcloudData.subPath) }} | ||
| {{- else }} | ||
| {{- if not (empty .Values.persistence.nextcloudData.subPath) }} |
Collaborator
There was a problem hiding this comment.
Please use
{{- with .Values.wasd }}
a: {{ . }}
{{- end }}
Instatt of
{{- if not (empty .Values.wasd) }}
a: {{ .Values.wasd }}
{{- end }}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/databack to the subPath in the values filePull Request
Description of the change
Fix #531
The datadir had the subPath-Suffix "/data" forced upon it and it was impossible
Possible drawbacks
If someone actually used the a different volume in the past, they will now need to add
/datato their subPath value.Applicable issues
/datasuffix #531Additional information
Checklist
Chart.yamlaccording to semver.