fix(nextcloud): truly not require SSE-C

[jstewart612]

Description of the change

Make SSE-C truly not be required just as the upstream project does not require SSE-C.

Benefits

Make SSE-C truly not be required just as the upstream project does not require SSE-C.

Possible drawbacks

None: only makes Helm chart more compliant with available upstream options.

Applicable issues

• fixes part of New S3 Configuration breaks prior S3 configuration and is missing uploadPartSize #612

Additional information

Checklist

• I have read the CONTRIBUTING.md doc.
• DCO has been signed off on the commit.
• Chart version bumped in Chart.yaml according to semver.
• (optional) Parameters are documented in the README.md

[jessebot]

Looks good, can be uncomplicated just a bit though :)

[jessebot]

Suggested change

	{{- if and (gt (len .Values.nextcloud.objectStore.s3.sse_c_key) 0) (lt (len .Values.nextcloud.objectStore.s3.secretKeys.sse_c_key) 1) }}
	{{- if .Values.nextcloud.objectStore.s3.sse_c_key }}

We don't actually need to calculate the length, as if this is not an empty string, it will trigger. My above suggestion should work fine.

[wrenix]

After the change, you should rebase and fix the version dump.

[wrenix]

change the order of evaluote first if sse_c_key is set (and then existingSecret) so that we has the name: OBJECTSTORE_S3_SSE_C_KEY just once and.
It is for me better readable (maybe we change the idea of if and with) ...

Suggested change

	{{- end }}
	{{- with .Values.nextcloud.objectStore.s3.sse_c_key }}
	- name: OBJECTSTORE_S3_SSE_C_KEY
	{{- if $.Values.nextcloud.objectStore.s3.existingSecret }}
	valueFrom:
	secretKeyRef:
	name: {{ $.Values.nextcloud.objectStore.s3.existingSecret }}
	key: {{ . | quote }}
	{{- else }}
	value: {{ . | quote }}
	{{- end }}
	{{- end }}