feat(cron): Allow additional cron jobs to be specified#794
feat(cron): Allow additional cron jobs to be specified#794flx5 wants to merge 1 commit intonextcloud:mainfrom
Conversation
Users should be able to specify additional cron jobs (for updating previews or running occ db:add-missing-indices automated) Signed-off-by: Felix Prasse <1330854+flx5@users.noreply.github.com>
| # Allow configuration of lifecycle hooks | ||
| # ref: https://kubernetes.io/docs/tasks/configure-pod-container/attach-handler-lifecycle-event/ | ||
| # Set securityContext parameters. For example, you may need to define runAsNonRoot directive | ||
| securityContext: { } |
There was a problem hiding this comment.
Should we really make everything reconfigurable? (labels, annotations, affinity, resources, securityContext ....)
Why not use a shell in current command: or here in additional just a different schedule and command
There was a problem hiding this comment.
I actually was thinking about just going for a bash -c "... && ..." style. To be honest I might be fine with that as well for my use case. Just some commands might be better to run on a different schedule than the normal cron job.
|
Hey @flx5, Even though I know that you have only implemented a loop there, in my opinion, essential features are missing, such as being able to define initContainers or custom containers. I would welcome the option of allowing users to define additional cronJobs, which would enable them to define initContainers or containers independently. After all, it is not a prerequisite that the cronJob must be executed in a nextcloud container image. They can use what THEY want. Volker |
Users should be able to specify additional cron jobs (for updating previews or running occ db:add-missing-indices automated)
Description of the change
Add configuration option to specify more cron jobs
Benefits
Users can run preview generation or update missing indices automatically
Possible drawbacks
Added complexity to the cron jobs
Checklist
Chart.yamlaccording to semver.