Skip to content

Comments

Add MacSyFinder modules for model management and protein system detection#10074

Draft
Copilot wants to merge 5 commits intomasterfrom
copilot/add-macsyfinder-module
Draft

Add MacSyFinder modules for model management and protein system detection#10074
Copilot wants to merge 5 commits intomasterfrom
copilot/add-macsyfinder-module

Conversation

Copy link

Copilot AI commented Feb 17, 2026

Adds support for MacSyFinder, a tool for detecting macromolecular systems in protein datasets using HMM-based similarity search.

Implementation

Two submodules following the tool's workflow:

  • macsyfinder/download: Fetches models via macsydata

    • Input: model name (e.g., 'TXSScan', 'CasFinder')
    • Output: models directory
  • macsyfinder/search: Executes system detection

    • Input: protein FASTA, models directory, optional model filter
    • Output: summary TSV, best solutions, complete results directory
    • Supports multiple database types: gembase (default), ordered_replicon, unordered

Usage

include { MACSYFINDER_DOWNLOAD } from './modules/nf-core/macsyfinder/download/main'
include { MACSYFINDER_SEARCH } from './modules/nf-core/macsyfinder/search/main'

MACSYFINDER_DOWNLOAD('TXSScan')

input_ch = Channel.of([
    [id: 'sample1', db_type: 'gembase'],
    file('proteins.faa')
])

MACSYFINDER_SEARCH(
    input_ch,
    MACSYFINDER_DOWNLOAD.out.models,
    'TXSScan'
)

Technical Details

  • Container: macsyfinder:2.1.6 from biocontainers
  • Both modules include complete meta.yml documentation and nf-test definitions
  • Search module captures HMMER version alongside MacSyFinder

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • api.anaconda.org
    • Triggering command: /usr/bin/curl curl -s REDACTED (dns block)
  • get.nextflow.io
    • Triggering command: /usr/bin/curl curl -s REDACTED (dns block)
  • https://api.github.com/repos/gem-pasteur/macsyfinder
    • Triggering command: /usr/bin/curl curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>new module: macsyfinder</issue_title>
<issue_description>### Is there an existing module for this?

  • I have searched for the existing module

Is there an open PR for this?

  • I have searched for existing PRs

Is there an open issue for this?

  • I have searched for existing issues

Further Information

MacSyFinder is a tool for detection of macromolecular systems in protein datasets using systems modelling and similarity search.

GitHub repo: https://github.com/gem-pasteur/macsyfinder

Are you going to work on this?

  • If I'm planning to work on this module, I added myself to the Assignees to facilitate tracking who is working on the module</issue_description>

<agent_instructions>Macsyfinder is compatible with models, they are here. We need to build models first and then run Macsyfinder, so it will be several sunmodules</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 4 commits February 17, 2026 10:36
Co-authored-by: brovolia <40294728+brovolia@users.noreply.github.com>
Co-authored-by: brovolia <40294728+brovolia@users.noreply.github.com>
Co-authored-by: brovolia <40294728+brovolia@users.noreply.github.com>
Co-authored-by: brovolia <40294728+brovolia@users.noreply.github.com>
Copilot AI changed the title [WIP] Add new module for MacSyFinder detection tool Add MacSyFinder modules for model management and protein system detection Feb 17, 2026
Copilot AI requested a review from brovolia February 17, 2026 10:42
@SPPearce
Copy link
Contributor

@copilot , please take a look at this: https://nf-co.re/docs/tutorials/migrate_to_topics/update_modules and ensure that you use the topic channel to emit the versions, rather than creating the versions.yml

@brovolia
Copy link
Contributor

Hi @SPPearce, thanks for pointing this! I've already modified it in my local environment. Could you kindly review this PR? Btw do you know how to fix the error from linter, which tells that md5sun for empty file is found? MSF produces this empty .err files intentionally and I can't change it

@mashehu
Copy link
Contributor

mashehu commented Feb 17, 2026

to fix the linting error make sure that the file is actually emtpy (with path(.out.err).text == "" please add the full channel name there).

@mashehu
Copy link
Contributor

mashehu commented Feb 17, 2026

this PR is also missing snapshot files

@brovolia
Copy link
Contributor

Sure, after linting my changes, I will push the snapshots here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: macsyfinder

4 participants