Add MacSyFinder modules for model management and protein system detection#10074
Draft
Add MacSyFinder modules for model management and protein system detection#10074
Conversation
Co-authored-by: brovolia <40294728+brovolia@users.noreply.github.com>
Co-authored-by: brovolia <40294728+brovolia@users.noreply.github.com>
Co-authored-by: brovolia <40294728+brovolia@users.noreply.github.com>
Co-authored-by: brovolia <40294728+brovolia@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add new module for MacSyFinder detection tool
Add MacSyFinder modules for model management and protein system detection
Feb 17, 2026
Contributor
|
@copilot , please take a look at this: https://nf-co.re/docs/tutorials/migrate_to_topics/update_modules and ensure that you use the topic channel to emit the versions, rather than creating the versions.yml |
Contributor
|
Hi @SPPearce, thanks for pointing this! I've already modified it in my local environment. Could you kindly review this PR? Btw do you know how to fix the error from linter, which tells that md5sun for empty file is found? MSF produces this empty .err files intentionally and I can't change it |
Contributor
|
to fix the linting error make sure that the file is actually emtpy (with |
Contributor
|
this PR is also missing snapshot files |
Contributor
|
Sure, after linting my changes, I will push the snapshots here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for MacSyFinder, a tool for detecting macromolecular systems in protein datasets using HMM-based similarity search.
Implementation
Two submodules following the tool's workflow:
macsyfinder/download: Fetches models via macsydatamacsyfinder/search: Executes system detectiongembase(default),ordered_replicon,unorderedUsage
include { MACSYFINDER_DOWNLOAD } from './modules/nf-core/macsyfinder/download/main' include { MACSYFINDER_SEARCH } from './modules/nf-core/macsyfinder/search/main' MACSYFINDER_DOWNLOAD('TXSScan') input_ch = Channel.of([ [id: 'sample1', db_type: 'gembase'], file('proteins.faa') ]) MACSYFINDER_SEARCH( input_ch, MACSYFINDER_DOWNLOAD.out.models, 'TXSScan' )Technical Details
macsyfinder:2.1.6from biocontainersWarning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
api.anaconda.org/usr/bin/curl curl -s REDACTED(dns block)get.nextflow.io/usr/bin/curl curl -s REDACTED(dns block)https://api.github.com/repos/gem-pasteur/macsyfinder/usr/bin/curl curl -s REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.