Skip to content

Comments

Nextflow lint cleanup sratools/prefetch#10109

Open
LouisLeNezet wants to merge 18 commits intonf-core:masterfrom
LouisLeNezet:modules_sra_cleanup
Open

Nextflow lint cleanup sratools/prefetch#10109
LouisLeNezet wants to merge 18 commits intonf-core:masterfrom
LouisLeNezet:modules_sra_cleanup

Conversation

@LouisLeNezet
Copy link
Contributor

@LouisLeNezet LouisLeNezet commented Feb 19, 2026

PR checklist

We need to fix the depreacted shell environment.
To do so multiple solution exist.
Here is a proposition.

  • We can keep the template but then we need to escape all $ in the script and echo all unused variable (cleaner)
  • We can call with bash the script and pass the variable either by positional argument or as environment variable.

I've updated the module to use topic and updated it to 3.2.1 as mentioned in phac-nml/fetchdatairidanext#30

@LouisLeNezet LouisLeNezet self-assigned this Feb 19, 2026
@LouisLeNezet LouisLeNezet marked this pull request as ready for review February 20, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant