Conversation
- Use template from rgi/main
- Use fastq pair instead of single fasta file
- add fastq extensions to 'pattern'
- Trying to pass linter
- build KMA/BWT index in workdir instead of program executable dir - update test snapshot
- Don't check temp/ directory on snapshot, is different every time - Update snapshot
- provide input.reads as list - don't check tsv snapshot (it's different every time)
- json files are in random order so snapshot differs every time (I think)
- Use '--local' flag as default
- Code review from nf-core#9585
- Create topics field in meta.yml
Co-authored-by: Jim Downie <19718667+prototaxites@users.noreply.github.com> Co-authored-by: James A. Fellows Yates <jfy133@gmail.com>
- capture topics appropriately in meta.yml
- Remove whitespace
- Fix escape character in versions output
SPPearce
reviewed
Feb 4, 2026
Code review for nf-core#9873 Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
Merge branch 'rgi/bwt' of github.com:vinisalazar/modules into rgi/bwt
SPPearce
reviewed
Feb 5, 2026
Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com>
vinisalazar
added a commit
to vinisalazar/test-datasets
that referenced
this pull request
Feb 9, 2026
Data for testing the rgi modules. See nf-core/modules#9873 for discussion.
vinisalazar
added a commit
to vinisalazar/test-datasets
that referenced
this pull request
Feb 11, 2026
Data for testing the rgi modules. See nf-core/modules#9873 for discussion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes:
This PR is a follow-up of #9585. See that for discussion.
PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda