Remove dependency on plugin lein-protobuf#55
Open
cesarbp wants to merge 4 commits intoninjudd:developfrom
Open
Remove dependency on plugin lein-protobuf#55cesarbp wants to merge 4 commits intoninjudd:developfrom
cesarbp wants to merge 4 commits intoninjudd:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the dependency on lein-protobuf. Compiled al the .proto files (including the tests) and placed them in a separate clojars repo. This is so users are not forced to download and compile protoc when they don't need it. This should also make this library work on windows.
I deleted the .proto files. I think they should be in their own project.