feat: Support RN New Architecture, improve bridge performance, use Expo Moduels API [WIP - Android-only]#93
Draft
gmaclennan wants to merge 12 commits intonodejs-mobile:mainfrom
Draft
feat: Support RN New Architecture, improve bridge performance, use Expo Moduels API [WIP - Android-only]#93gmaclennan wants to merge 12 commits intonodejs-mobile:mainfrom
gmaclennan wants to merge 12 commits intonodejs-mobile:mainfrom
Conversation
…nce improvements Major architectural improvements: - Convert from thread-based to coroutine-based async operations - Replace Semaphore with CompletableDeferred for proper initialization signaling - Add structured concurrency with CoroutineScope and proper cleanup Performance optimizations: - Implement parallel file copying with semaphore-limited concurrency (max 8) - Convert all I/O operations to suspend functions with Dispatchers.IO - Add parallel processing to asset folder copying and native assets - Replace manual file operations with efficient Kotlin stdlib methods API improvements: - Convert string path parameters to File objects for type safety - Replace verbose boolean extraction with reusable extension function - Modernize file operations using buffered streams and proper resource management - Remove redundant wrapper functions and simplify error handling Code quality enhancements: - Replace wildcard imports with specific imports for better clarity - Convert properties from string paths to File instances - Eliminate race conditions in initialization with proper async coordination - Add comprehensive error handling with structured exception propagation - Simplify recursive file deletion using Kotlin's deleteRecursively() Threading model improvements: - Replace Thread creation with coroutine launch for all background operations - Use proper dispatchers (Main for React Native events, IO for file operations) - Implement cancellable operations that respect module lifecycle - Add semaphore-based resource limiting to prevent system overload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves this module to use the Expo Modules API with support for the React Native New Architecture with performance optimizations for bridge messaging resulting in 2.3x to 4.1x faster message throughput.
🚀 Performance Results
Message Processing Benchmark
Sending/receiving 1,000 JSON messages, randomly generated:
Per-Message Performance
🔧 Key Optimizations
1. Message Batching in libuv Callbacks
2. Main Thread Elimination for Message Dispatch
Benefits:
3. JNI Performance Improvements
4. Smart Async Notification
uv_async_send()calls for rapid message bursts5. Async Initialization with Coroutines
Initialization Improvements:
6. Architecture Modernization
📊 Technical Overview
Message Processing Pipeline Improvements
Thread Synchronization Benefits
The new implementation improves thread synchronization by:
Initialization Performance
🏗️ Breaking Changes
com.janeasystems.*tocom.nodejsmobile.reactnative.*🧪 Testing
Benchmarking performed using a dedicated test app with: