This repository was archived by the owner on Oct 15, 2020. It is now read-only.
build: fix ./configure --xcode failure#376
Open
tommyZZM wants to merge 2 commits intonodejs:masterfrom
Open
Conversation
Contributor
|
I guess that you assume this work if you have compiled chakracore already? And don't include ChakraCore in xcode? |
Author
|
hi @obastemur
|
Contributor
They are there because of Besides, the changes to configure needs some attention. Thanks for the attempt. This; being automated, may require a bit more hacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make
./configure --xcodeis able to generate.xcodeprojand build all targets successfullyreference: #297
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
None