Conversation
PR-URL: #49079 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
fs.write(v) is not guaranteed to write everything in a single call. Make sure we don't assume so. PR-URL: #49211 Co-authored-by: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Notable changes: This release addresses some regressions that appeared in Node.js 18.18.0: - (Windows) FS can not handle certain characters in file name #48673 - 18 and 20 node images give error - Text file busy (after re-build images) nodejs/docker-node#1968 - libuv update in 18.18.0 breaks webpack's thread-loader #49911 The libuv 1.45.0 and 1.46.0 updates that were released in Node.js 18.18.0 have been temporarily reverted. PR-URL: #50065
|
Review requested:
|
nodejs-github-bot
added
meta
|
@richardlau There are couple of bugs that Ada's latest releases fixed such as a segfault, and a crash on hostname setter. Since they're isolated commits, I recommend including them in this release. |
|
@anonrig Those haven't been released in a current release yet so are not normally considered for inclusion in LTS. |
|
Not sure what those lint failures are -- they're not in any of the files changed by this proposal. I'll close and open a new PR in case it was due to be swapping the base branch. |
Even though I agree, Ada's latest releases fixes easily reproducible cases/crashes in the most commonly used module in Node. If we can take an incentive to land them, I strongly recommend adding them. But in the end, it's your call and I respect that. |
#50066 -- linters are passing there so it must have been some issue with opening the PR on the wrong base branch. |
5 participants
2023-10-10, Version 18.18.1 'Hydrogen' (LTS), @richardlau
Notable Changes
This release addresses some regressions that appeared in Node.js 18.18.0:
The libuv 1.45.0 and 1.46.0 updates that were released in Node.js 18.18.0 have been temporarily reverted.
Commits
3e3a75cc46] - Revert "build: sync libuv header change" (Richard Lau) #5003614ece2c479] - Revert "deps: upgrade to libuv 1.45.0" (Richard Lau) #50036022352acbe] - Revert "deps: upgrade to libuv 1.46.0" (Richard Lau) #50036d9f138189c] - Revert "deps: add missing thread-common.c in uv.gyp" (Richard Lau) #500367a3e1ffbb8] - fs: make sure to write entire buffer (Robert Nagy) #4921104cba95a67] - test: addtmpdir.resolve()(Livia Medeiros) #49079cc @nodejs/lts
Note that this is not a "full" Node.js 18 release -- it is a "quick" release to fix the regressions noted above that were introduced in Node.js 18.18.0. I will not have time to do a full Node.js release this month, so any requests for additions to this release will likely be denied unless a very strong case can be made.