Skip to content

Conversation

@dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Feb 1, 2026

Description

As per the open-next docs, in the wrangler configuration there should be a WORKER_SELF_REFERENCE service binding (that is used by open-next for caching): https://opennext.js.org/cloudflare/get-started#3-create-a-wrangler-configuration-file

This PR is adding this service binding to the wrangler configuration since it is currently missing

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner February 1, 2026 19:31
Copilot AI review requested due to automatic review settings February 1, 2026 19:31
@vercel
Copy link

vercel bot commented Feb 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Ready Ready Preview Feb 1, 2026 7:32pm

Request Review

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2026

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/web-infra

Please review the changes when you have a chance. Thank you! 🙏

@codecov
Copy link

codecov bot commented Feb 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.01%. Comparing base (ec36423) to head (518f55a).
⚠️ Report is 14 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8589   +/-   ##
=======================================
  Coverage   75.01%   75.01%           
=======================================
  Files         103      103           
  Lines        9036     9037    +1     
  Branches      311      311           
=======================================
+ Hits         6778     6779    +1     
  Misses       2256     2256           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the missing WORKER_SELF_REFERENCE service binding to the Wrangler configuration file, which is required by OpenNext for caching functionality as documented in the OpenNext Cloudflare documentation.

Changes:

  • Added services array with WORKER_SELF_REFERENCE binding pointing to the nodejs-website worker

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@flakey5 flakey5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@flakey5
Copy link
Member

flakey5 commented Feb 1, 2026

requesting fast track

@MattIPv4 MattIPv4 added the fast-track Fast Tracking PRs label Feb 1, 2026
@MattIPv4 MattIPv4 enabled auto-merge February 1, 2026 19:57
@MattIPv4 MattIPv4 added this pull request to the merge queue Feb 1, 2026
Merged via the queue into nodejs:main with commit e15d875 Feb 1, 2026
24 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/missing-WORKER_SELF_REFERENCE branch February 1, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-track Fast Tracking PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants