Draft
Conversation
- The `make -j 1` workaround seems neither in effect nor necessary anymore - Assume that KERNEL_BITS workaround isn't necessary anymore - Declare more variables as local
The default settings for LDFLAGS and CPPFLAGS were there since the initial commit to ruby-build:
LDFLAGS="-L${PREFIX_PATH}/lib"
CPPFLAGS="-I${PREFIX_PATH}/include"
However, it's not clear to me what these settings help with. A typical Ruby installation will initialize files in these directories, but it will do so regardless of the environment variables.
So, let's remove them and see what breaks.
…the command line Same with linking libyaml, gmp, etc. to Homebrew. This considers all user configuration inputs when checking for existing flags.
Reuse original `build_package_copy` instead of having to maintain an additional `build_package_copy_to` step. As a bonus, this prevents a global variable `to` from leaking.
Avoid compiling OpenSSL if the user supplied `--with-openssl-dir` on the command line
Cleanup in OpenSSL compilation step
Remove implicit LDFLAGS, CPPFLAGS, and "ldflags_dirs" build step
- Now only generates a `configure` script if explicitly specified - Add ability to add arbitrary files to the tarball - Cache most common tarballs in fixtures directory to speed up tests
Add tests for functionality related to linking to OpenSSL
Add JRuby 9.4.4.0
TruffleRuby build definitions used to explicitly rely on `brew --prefix openssl@1.1` on macOS and abort installation if that was not found. However, this check didn't take into account that the user might have set OPENSSL_PREFIX in their environment, or that they have another `openssl@*` version installed via Homebrew. This change removes the `use_homebrew_openssl` check and allows TruffleRuby to perform its own OpenSSL detection. https://github.com/oracle/truffleruby/blob/vm-23.1.0/lib/truffle/truffle/openssl-prefix.rb#L14-L17
This is to allow JRuby itself to check for compatible OpenSSL versions and not have ruby-build abort early on macOS.
LC_CTYPE is "utf-8" on macOS, which instructs utilities like `tr` to expect Unicode input. However, in case of binary files, which we here explicitly guard against, the utility will fail because of invalid input encoding. The solution is to set LC_CTYPE=C which effectively removes the expectation around input encoding and allows `tr` to process the input byte-by-byte.
Bump up OpenSSL 3.1.4
* commit 'refs/rbtags/v20231025': ruby-build 20231025 Add TruffleRuby and TruffleRuby GraalVM 23.1.1 Bump up OpenSSL 3.1.4 Skip ri/rdoc when installing jruby-launcher Fix fixing JRuby shebangs on macOS JRuby: remove `openssl@1.1` requirement from `jruby-dev` TruffleRuby: remove explicit `openssl@1.1` requirement on macOS Add JRuby 9.4.4.0 Add `needs_openssl` test Improve `cached_tarball` test helper Avoiding excessive cd when fetching git repos (#2273) Cleanup in truffleruby+graalvm installation Avoid compiling OpenSSL if the user supplied `--with-openssl-dir` on the command line Remove "ldflags_dirs" step from build definitions Remove implicit LDFLAGS, CPPFLAGS, and "ldflags_dirs" build step Cleanup in openssl compilation step
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.