Conversation
It seems like we're currently using vite-plus solely for running tests. It caused issues in the past that forced us to migrate away from it in most places (vite fmt, vite lint running postinstall and causing severe delays). It currently crashes on Windows arm64 machines. It is also explicitly said: > Vite+ is not yet stable and should not be used in production. With that in mind, vite-plus does not provide a lot of value to the project at the moment and therefore I propose removing it for now.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
There was a problem hiding this comment.
Pull request overview
This PR removes the experimental vite-plus package that was causing compatibility issues on Windows arm64 machines. The package was only being used for testing and is explicitly marked as unstable. The migration replaces vite-plus with the standard stable versions of vite and vitest.
Changes:
- Removed vite-plus package overrides from pnpm workspace configuration
- Updated all test scripts from
vite testtovitest - Removed vite-plus dependency entries from package.json and knip configuration
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Removed vite and vitest overrides that aliased to vite-plus packages |
| pnpm-lock.yaml | Updated dependency tree to use standard vite/vitest instead of vite-plus variants |
| package.json | Updated test scripts to use vitest command and removed vite-plus dependencies |
| knip.ts | Removed vite-plus from ignored dependencies list |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRemoved two packages from knip.ts ignoreDependencies: '@voidzero-dev/vite-plus-core' and 'vite-plus'. package.json updated: test scripts now run vitest with project flags, Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 1✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
caught up the branch for you. i agree we should use vitest until the void zero branch is stable enough. |
|
if we can itemise issues we can pester @TheAlexLichter to fix them 👀 |
|
In all cases, please send issues! This is super valuable for the upcoming alpha and to improve Vite+ further. |
|
I think voidzero-dev/vite-plus-discussions#9 is the most pesky one right now. |
4 participants
It seems like we're currently using vite-plus solely for running tests. It caused issues in the past that forced us to migrate away from it in most places (vite fmt, vite lint running postinstall and causing severe delays). It currently crashes on Windows arm64 machines. It is also explicitly said:
With that in mind, vite-plus does not provide a lot of value to the project at the moment and therefore I propose removing it for now.